lint: Increase max-module-lines to 3000 #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willschlitzer
approved these changes
Jan 24, 2021
There was a problem hiding this comment.
Good change. Hopefully this gets fixed in #685 relatively soon, but this will keep every change to base_plotting.py from auto-failing its style checks.
weiji14
added
maintenance
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
We have these linting issues because base_plotting.py is too long: ``` pygmt/base_plotting.py:1:0: C0302: Too many lines in module (2047/2000) (too-many-lines) ``` The problem will be fixed in GenericMappingTools#685, but it may take some time. This PR increases the max-module-lines to 3000 to temporarily disable the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
We have these linting issues because
base_plotting.pyis too long:The problem will be fixed in #685, but it may take some time.
This PR increases the max-module-lines to 3000 to temporarily disable the warning.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Notes
/formatin the first line of a comment to lint the code automatically