Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate tests of tutorial dataset and earth_relief dataset into two files #978

Merged
merged 2 commits into from
Feb 28, 2021
Merged

Separate tests of tutorial dataset and earth_relief dataset into two files #978

merged 2 commits into from
Feb 28, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Feb 28, 2021 •
edited
Loading

Description of proposed changes

Similar to what we're doing to other tests, we should split the tests in test_datasets.py into two files test_datasets_tutorial.py and test_datasets_earth_relief.py.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added this to the 0.3.1 milestone Feb 28, 2021
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 28, 2021
@seisman seisman requested a review from a team February 28, 2021 05:09
@seisman seisman force-pushed the split-test-datasets branch from 15896ae to fec3f64 Compare February 28, 2021 05:18
@seisman @willschlitzer
Fix docstrings
37c85e5 
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
@seisman seisman merged commit 1b4aa90 into master Feb 28, 2021
@seisman seisman deleted the split-test-datasets branch February 28, 2021 21:59
@seisman seisman mentioned this pull request Feb 28, 2021
Merged
5 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman @willschlitzer
Separate tests of tutorial dataset and earth_relief dataset into two …
699cd63 
…files (GenericMappingTools#978)

Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willschlitzer willschlitzer willschlitzer approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@seisman @willschlitzer