Setup test environment inside CI #9

FrankUrbach · 2021-12-21T19:21:02Z

Purpose of the PR:

Setting up a test database inside CI.

Remarks:
Only test of relations are included. Further test scenarios are needed.

for the tests

SearchLight

…/2021-06-15-00-40-40-218-2413546544' compatible issue

essenciary · 2022-01-05T15:03:03Z

.gitignore

Why did you remove Manifest.toml from .gitignore?

uups. Added again.

essenciary · 2022-01-05T15:04:06Z

Project.toml

@@ -7,7 +7,10 @@ version = "2.0.1"
 DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
 LibPQ = "194296ae-ab2e-5f79-8cd4-7183a0a5a0d1"
 Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
+Revise = "295af30f-e4ad-537b-8983-00126c2a3abe"


Why are all these dependencies added to the project?
a) do we need Revise at all?
b) the test dependencies shouldn't go to the test project?

a) Revise is not needed and is removed now
b) will change this

essenciary · 2022-01-05T15:04:50Z

src/SearchLightPostgreSQL.jl


-  @info "Created table $table_name"
+  queryString = string("select table_name from information_schema.tables where table_name = '$table_name'")


Can you please use uppercase for SQL, like we use everywhere else? Eg: "SELECT table_name FROM ... WHERE ...".

Also, what is the need for string(...)?

both requests are changed.

essenciary · 2022-01-05T15:08:25Z

test/models.jl

+            )
+  end
+
+  mutable struct BookWithInterns <: AbstractModel


Can you please update/cleanup the model to the latest API? We no longer use the _table_name, _id, _serializable fields. Just so that it's not confusing for the users looking at the tests to learn.

essenciary

Can you please remove the .DS_Store files and add them to .gitignore?

essenciary · 2022-01-05T15:37:35Z

.github/workflows/Test_DB.yml

+      - uses: actions/checkout@v2
+      - uses: julia-actions/setup-julia@latest
+        with:
+          version: '1.6.4'


Bump to 1.7?

essenciary · 2022-01-05T15:37:48Z

.github/workflows/Test_DB.yml

+      - name: Install SearchLight and SearchLightPostgreSQL
+        run: |
+          pwd
+          julia -e 'using Pkg; Pkg.add(url="https://github.com/FrankUrbach/SearchLight.jl.git")'


Link to official packages?

the test depencies from the main .toml file

essenciary · 2022-01-17T20:02:25Z

Project.toml

 LibPQ = "194296ae-ab2e-5f79-8cd4-7183a0a5a0d1"
 Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
 SearchLight = "340e8cb6-72eb-11e8-37ce-c97ebeb32050"

 [compat]
-DataFrames = "1"


@FrankUrbach You removed the compat entry for DataFrames - pls put it back

essenciary · 2022-01-17T20:03:43Z

src/SearchLightPostgreSQL.jl


-  @info "Created table $table_name"
+  queryString = "SELECT table_name FROM information_schema.tables WHERE table_name = '$table_name'"


Please use naming consistent with the rest of the code base. In SearchLight (and Julia in general) we use query_string not queryString.

essenciary · 2022-01-17T20:05:04Z

.gitignore

+Manifest.toml
+tests/db/migrations/*
+**/.DS_Store*


Can you also delete the .DS_Store files that were added?

FrankUrbach and others added 30 commits November 18, 2020 17:13

Added Test and new_table_migration

dc455d5

not realy changed something

05f8d39

changed Project.toml

a44e9bb

save array of AbstractModels

18ac63a

begin test for structs with intern variables

7a1b7a9

intermediate state

bf54b29

begin test saving without interns

28c332b

change the testfolder to the tests subfolder

319764f

ended the change to /tests as projectfolder

4910a4b

for the tests

created a test scenario for Issue#31 of

594fb90

SearchLight

Merge branch 'Issue#31'

541e94a

fullfilled merge actions

ecd1f91

nothing reali heavy

91e9172

CompatHelper: bump compat for "SearchLight" to "0.22"

82fef68

Only the first save after a long time

c34da91

Merge remote-tracking branch 'GenieFramework/compathelper/new_version…

103ea5a

…/2021-06-15-00-40-40-218-2413546544' compatible issue

Test with DB included

2506a2d

Merge remote-tracking branch 'forkAtGithub/master'

c81b6a9

changed compats

962dadd

MySQL tests rausgeworfen

c9293be

create a database in the CI tests

ee66d2f

creating database changed

b245dba

next change

7b3ba2d

next round tests

5091c33

next

5c5c0ac

next atempt

3f7e40b

next

cbf55bc

next

63ff491

next

b9e9535

next

0df8530

FrankUrbach added 8 commits December 14, 2021 13:02

failure in database now?

4cef381

changed for tests

62457b7

removed error

7071fcd

next step

d970f20

next step

bf8bf00

typo

b16713a

pkg Dates included

8839aa7

Merge remote-tracking branch 'GenieFramework/master'

8ab9ce9

essenciary reviewed Jan 5, 2022

View reviewed changes

changed_gitignore

439f590

essenciary reviewed Jan 5, 2022

View reviewed changes

FrankUrbach added 3 commits January 5, 2022 17:02

changes requested by review PR#9

4f4a9f1

added Pkg package, Tests should run on 1.7.1

5679d6a

added the needed packages for tests

3f1fa9a

FrankUrbach requested a review from essenciary January 5, 2022 16:39

dir change needed for reaching db/migrations folder

d569a33

FrankUrbach mentioned this pull request Jan 14, 2022

Setting up test environment GenieFramework/SearchLightMySQL.jl#6

Merged

FrankUrbach added 5 commits January 15, 2022 12:48

changed the Project.toml files to remove

0937725

the test depencies from the main .toml file

removed .DS_Store file

c8d0b9a

changed .gitignore file

19e090a

Merge remote-tracking branch 'forkAtGithub/master'

c997f8f

removed .DS_Store file

1c1d4a7

essenciary reviewed Jan 17, 2022

View reviewed changes

.gitignore

Manifest.toml

tests/db/migrations/*

**/.DS_Store*

Copy link

Member

essenciary Jan 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also delete the .DS_Store files that were added?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup test environment inside CI #9

Setup test environment inside CI #9

FrankUrbach commented Dec 21, 2021

essenciary Jan 5, 2022

FrankUrbach Jan 5, 2022

essenciary Jan 5, 2022

FrankUrbach Jan 5, 2022

essenciary Jan 5, 2022 •

edited

Loading

FrankUrbach Jan 5, 2022

essenciary Jan 5, 2022

essenciary left a comment

essenciary Jan 5, 2022

essenciary Jan 5, 2022

essenciary Jan 17, 2022

essenciary Jan 17, 2022

essenciary Jan 17, 2022


		@info "Created table $table_name"
		queryString = string("select table_name from information_schema.tables where table_name = '$table_name'")


		@info "Created table $table_name"
		queryString = "SELECT table_name FROM information_schema.tables WHERE table_name = '$table_name'"

Setup test environment inside CI #9

Are you sure you want to change the base?

Setup test environment inside CI #9

Conversation

FrankUrbach commented Dec 21, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

essenciary Jan 5, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

essenciary left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

essenciary Jan 5, 2022 •

edited

Loading