Skip to content

Commit

Permalink
Pass bidderRequestId parameter in Adform adapter (prebid#1888)
Browse files Browse the repository at this point in the history
* bid response adId same as bidId

* Add auctionId

* Update adapter for auctionId
  • Loading branch information
Pupis authored and dbemiller committed Nov 28, 2017
1 parent 18fe42d commit 59800f4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions modules/adformBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ function AdformAdapter() {

request.unshift('//' + globalParams[0][1] + '/adx/?rp=4');

request.push('auctionId=' + encodeURIComponent(params.bidderRequestId));
for (i = 1, l = globalParams.length; i < l; i++) {
_key = globalParams[i][0];
_value = globalParams[i][1];
Expand Down
2 changes: 2 additions & 0 deletions test/spec/modules/adformBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ describe('Adform adapter', () => {
assert.equal(_query.tid, 145);
assert.equal(_query.rp, 4);
assert.equal(_query.fd, 1);
assert.equal(_query.auctionId, '1a2b3c');
assert.equal(_query.url, encodeURIComponent('some// there'));
});

Expand Down Expand Up @@ -117,6 +118,7 @@ describe('Adform adapter', () => {
sandbox = sinon.sandbox.create();
sandbox.stub(adLoader, 'loadScript');
_adformAdapter.callBids({
bidderRequestId: '1a2b3c',
bids: [
{
bidId: 'abc',
Expand Down

0 comments on commit 59800f4

Please sign in to comment.