Make the render window a native Wayland window

[PatrickJosh]

• I have checked that a similar feature request does not already exist.

Is your feature request related to a problem? Please describe.
Currently, when using fractional scaling in GNOME with Wayland, the render window is slightly blurry. This happens to all applications that use XWayland instead of native Wayland as display server.

Describe the solution you'd like
Make the render window a native Wayland window so that it does not use the XWayland server anymore.

Describe alternatives you've considered
An alternative for me would be not to use Wayland or fractional scaling, but I do not consider both as sensible options. I have not thought about other options, I do not know if there are any.

Additional context
A screenshot to show the slight blurriness. You can see it best if you compare the text of the terminal with the headline of the render window.

[rom1v]

I guess this should be handled by SDL, could you please also report the problem to them?

[PatrickJosh]

Sure, sorry. I did not know that.

[PatrickJosh]

With a bit of search, I found this pull request in SDL's repository. With SDL_VIDEODRIVER=wayland scrcpy, it is indeed possible to run scrcpy with Wayland. However, the window does not have any decorations then, but the corresponding pull request is merged. Is this still an issue with SDL or now with scrcpy?

[PatrickJosh]

I manually fixed it by building scrcpy myself with having libdecor development files installed. Now the window has decorations. Maybe future versions of scrcpy could include libdecor as a requirement so that decorations are available with the prebuild binaries as well?

[PatrickJosh]

I noticed, directly after I have written the last comment, that the decorations are also available with the prebuild version, at least on Fedora, when libdecor is installed. So, libdecor should maybe be a dependency for the installation of scrcpy on Linux, at least on the distros that use Wayland by default now (Fedora, Ubuntu)? If this is not an option, in my opinion at least a note in the FAQ should be added.

[rom1v]

d6aaa5b

https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#issue-with-wayland

[zenofile]

I added libdecor as runtime dependency for https://copr.fedorainfracloud.org/coprs/zeno/scrcpy/.

[rom1v]

@zenofile Thanks.

May I remove:

On some distributions (at least Fedora), the package libdecor must be installed manually.

from the FAQ then?

[zenofile]

@zenofile Thanks.

May I remove:

On some distributions (at least Fedora), the package libdecor must be installed manually.

from the FAQ then?

If the user decides to use the prebuilt binaries instead of the copr repository (or when using other distributions?), it might still be necessary to install libdecor manually. So I would recommend altering the text to something like:

On distributions that do not include libdecor as a runtime dependency when installing scrcpy via the package manager or when using the prebuilt binaries, it may need to be installed manually.

instead of removing it completely.

[xerpi]

With a bit of search, I found this pull request in SDL's repository. With SDL_VIDEODRIVER=wayland scrcpy, it is indeed possible to run scrcpy with Wayland. However, the window does not have any decorations then, but the corresponding pull request is merged. Is this still an issue with SDL or now with scrcpy?

You can override the SDL version an executable is linked to (scrcpy in your case) and provide your own SDL .so:

SDL_VIDEODRIVER=wayland SDL_DYNAMIC_API=/path/to/your/SDL/build/.libs/libSDL2-2.0.so.0

It might be useful while waiting until the latest SDL version reaches the repos of the distros.