Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update info of scaling issue in FAQ.md #3028

Closed
1 task done
NewUserHa opened this issue Feb 17, 2022 · 5 comments · Fixed by #3032
Closed
1 task done

update info of scaling issue in FAQ.md #3028

NewUserHa opened this issue Feb 17, 2022 · 5 comments · Fixed by #3032
Labels

Comments

@NewUserHa
Copy link

https://github.com/Genymobile/scrcpy/blob/master/FAQ.md#the-quality-is-low seems to be outdated now.

actually, I found when the screen resolution or the window is way smaller than the desktop resolution(like 4k), the upscaling result is not as clear as the scrcpy 1.22 with DPIawareness on.

So the FAQ.md should encourage the users to update to the least version as first solution, than Override high DPI scaling behavior, then than try opengl

@rom1v rom1v added the todo label Feb 17, 2022
rom1v added a commit that referenced this issue Feb 17, 2022
Recommend to update to v1.22 before suggesting manual configuration.

Fixes #3028 <#3028>
@rom1v
Copy link
Collaborator

rom1v commented Feb 17, 2022

Please review #3032.

@NewUserHa
Copy link
Author

👍

@rom1v rom1v closed this as completed in 0e22032 Feb 18, 2022
@NewUserHa
Copy link
Author

NewUserHa commented Feb 18, 2022

Is it possible without opengl to use better filters like lanczos3, bicubic, etc. for up/downscaling?
because if the window is not the same size as the native resolution of the device screen, the image is still be resized/up/downscaled.

@rom1v
Copy link
Collaborator

rom1v commented Feb 18, 2022

@NewUserHa Basically, no: #40 (comment)

@NewUserHa
Copy link
Author

NewUserHa commented Feb 18, 2022

I saw scrcpy use ffmpeg library, what process(like filters, renders) does scrcpy use to the image received from the device?

For my 1440x3120 device, bicubic swscaling takes between 20ms and 60ms (...

I saw the madvr render report that the render time it costs is about only 10ms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants