Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touchscreen not captured properly without --no-mouse-hover #5067

Closed
ScionOfDesign opened this issue Jul 7, 2024 · 7 comments · Fixed by #5076
Closed

Touchscreen not captured properly without --no-mouse-hover #5067

ScionOfDesign opened this issue Jul 7, 2024 · 7 comments · Fixed by #5076

Comments

@ScionOfDesign
Copy link

Environment

  • OS: Windows 11
  • Scrcpy version: 2.5
  • Installation method: Windows Release 64 bit
  • Device model: Orange Pi
  • Android version: 12

Describe the bug

When running scrcpy.exe with no flags, it works fine with the mouse. However, attempting to use the touchscreen either does not work at all or only sometimes works for a little bit.
Adding the flag --no-mouse-hover causes touchscreen input to be captured again.
@rom1v
Copy link
Collaborator

rom1v commented Jul 7, 2024

Please run with scrcpy -Vverbose and post the whole output when it fails to inject touchscreen events.

@ScionOfDesign
Copy link
Author

ScionOfDesign commented Jul 7, 2024 •
edited
Loading

Here is the log:
Scrcpy.log

I alternated between touch and mouse.

@rom1v
Copy link
Collaborator

rom1v commented Jul 7, 2024

Thank you.

Out of curiosity, does it work with scrcpy --mouse-bind=++++?

@ScionOfDesign
Copy link
Author

ScionOfDesign commented Jul 7, 2024 •
edited
Loading

Thank you.

Out of curiosity, does it work with scrcpy --mouse-bind=++++?

Yes, it does seem to work with that flag.

@rom1v
Copy link
Collaborator

rom1v commented Jul 7, 2024

OK 👌

I will probably rework the decision to inject mouse or finger. Refs #5055 (comment)

rom1v added a commit that referenced this issue Jul 8, 2024
@rom1v
Make pointer id independent of mouse bindings
90a1a62 
The tool type (MOUSE or FINGER) to use depended on whether a secondary
click was possible via mouse bindings.

As a first step, always use a mouse tool type to break this dependency.
Note that this change might cause regressions in some (unknown) cases
(refs f70359f), but hopefully not.

Further commits will restore a finger tool type in some specific use
cases, but independent of secondary clicks.

Refs #5055 <#5055>
Refs #5067 <#5067>
rom1v added a commit that referenced this issue Jul 9, 2024
@rom1v
Make pointer id independent of mouse bindings
8e9a163 
The device source (MOUSE or FINGER) to use depended on whether a
secondary click was possible via mouse bindings.

As a first step, always use a mouse source to break this dependency.
Note that this change might cause regressions in some (unknown) cases
(refs f70359f), but hopefully not.

Further commits will restore a finger source in some specific use cases,
but independent of secondary clicks.

Refs #5055 <#5055>
Refs #5067 <#5067>
@rom1v rom1v mentioned this issue Jul 9, 2024
Merged
@rom1v
Copy link
Collaborator

rom1v commented Jul 9, 2024

Fixed by #5076. Please test and confirm that it works 😉

@ScionOfDesign
Copy link
Author

Yes, this seems to work. Thank you!

@rom1v rom1v closed this as completed in 6808288 Aug 1, 2024
FreedomBen pushed a commit to FreedomBen/scrcpy that referenced this issue Aug 2, 2024
@rom1v @FreedomBen
Make pointer id independent of mouse bindings
8bb46e2 
The device source (MOUSE or FINGER) to use depended on whether a
secondary click was possible via mouse bindings.

As a first step, always use a mouse source to break this dependency.
Note that this change might cause regressions in some (unknown) cases
(refs f70359f), but hopefully not.

Further commits will restore a finger source in some specific use cases,
but independent of secondary clicks.

Refs Genymobile#5055 <Genymobile#5055>
Fixes Genymobile#5067 <Genymobile#5067>
PR Genymobile#5076 <Genymobile#5076>
@rom1v rom1v mentioned this issue Aug 2, 2024
Closed
Gottox pushed a commit to Gottox/scrcpy that referenced this issue Sep 29, 2024
@rom1v @Gottox
Make pointer id independent of mouse bindings
2b97ac6 
The device source (MOUSE or FINGER) to use depended on whether a
secondary click was possible via mouse bindings.

As a first step, always use a mouse source to break this dependency.
Note that this change might cause regressions in some (unknown) cases
(refs f70359f), but hopefully not.

Further commits will restore a finger source in some specific use cases,
but independent of secondary clicks.

Refs Genymobile#5055 <Genymobile#5055>
Fixes Genymobile#5067 <Genymobile#5067>
PR Genymobile#5076 <Genymobile#5076>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve mouse events and add secondary bindings Genymobile/scrcpy
2 participants
@rom1v @ScionOfDesign