--time-limit=2600 times out immediately on Windows #5355
Comments
rom1v
added a commit
that referenced
this issue
Oct 8, 2024
With the old macros definitions, the type of the result depended on the type of `sec`. In particular, if sec is a 32-bit type, sec * 1000000 was likely to overflow (even if the result was assigned to a sc_tick by the caller of the macro). This was the case on Windows, where the long type is a 32-bit signed integer: the --time-limit argument, expressed in seconds, was first parsed to a long value, then multiplied by 1000000 by the SC_TICK_FROM_SEC() macro, causing an overflow when the value was greater than 2147 (2^31 / 1000000). Fixes #5355 <#5355>
|
Fixed by afbaf59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please read the prerequisites to run scrcpy.
Also read the FAQ and check if your issue already exists.
Environment
Describe the bug
Reported on reddit:
The text was updated successfully, but these errors were encountered: