-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new option for falling back to clipboard pasting on character injection failures. #1805
base: dev
Are you sure you want to change the base?
Adding new option for falling back to clipboard pasting on character injection failures. #1805
Conversation
…injection failures.
Hi, Thank you for the proposal. Using this method to inject text has drawbacks: #1426 (comment) |
@npes87184 Any opinion about this? |
I don't like this workaround. From my point of view, instead of adding an option that will be removed eventually, we should find time to actually implement the IME into scrcpy to resolve the problem correctly. BTW, @rom1v I guess you are doing static build for client now, right? |
Does it work fine for you when you type chinese? One advantage is that it may work without installing an app. Do you think that it could be enabled by default when the character may not be injected (so that there is no new option)?
No, until #1753 is solved, I use the last version of FFmpeg built by zeranoe. |
I will give it a try recently (maybe tonight if possible). Yes, without needing to install an app is a benefit in this method and I haven't noticed this.
Because the benefit of not having to install apps, I change my mind, I think it is worth to add this workaround in this time. However, too many options is also a problem now. If possible, I stand for not adding new option for this method.
Ok, I will take a look in my free time for static build. BTW, don't give high expectation, I am really busy recently :P. |
It doesn't work for me. I ran scrcpy with
|
Hmm I'm sorry to know that. I also used an IME for Chinese for testing, and the environments are:
Could you share some info on your side so I may have a look? |
Is there any progress for this PR? @rom1v @npes87184 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the system
Please test the new @npes87184 Does IME work perfectly with HID? |
7e8a942
to
c0de365
Compare
So that non-ASCII characters may be entered via IMEs. Resolves #37.
Submitting the changes here for now for review. Further documentation work would be needed on
README.md
andFAQ.md
either in this PR or as separate ones if this gets merged early.