Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scrcpy-console.bat #3418

Closed
wants to merge 0 commits into from
Closed

Conversation

MrLeopard
Copy link

easy to use when multiple devices connected.
requirement : #3137

@rom1v
Copy link
Collaborator

rom1v commented Aug 6, 2022

Thank you for your proposal.

If we really want this interaction with the user, it should not be in scrcpy-console.bat (which is only a script for Windows users to double-click without closing the terminal on error).

But scrcpy, by default, should not be interactive either (there might be no console, or it may be started from scripts, which are not expected to wait). An --interactive command line option could enable it, but then, it's useless (people do not explicitly pass the flag).

Since the command gives the list of users with their serial/ip, ready to be copy-pasted, I'm not sure it's worth it.

Ideally, I'd like scrcpy to be exposed as a library, and develop an alternative UI, which would expose the list of devices. But that requires a lot of work, that I cannot do on my free time.

@MrLeopard
Copy link
Author

Thanks for your replay.

When multiple devices connected, they have to use command line to run the programme, and I saw some guys also troubled by this design--#3137,#3005,#1965,#485

I read your opinion :

"but scrcpy could not rely on user input"

So I thought how about just changing the script file scrcpy-console.bat, then I wrote this bat file, it just help people set ANDROID_HOME environment variable, scrcpy core not changed, but fresh user not need to see multiple devices error.

Thanks for your reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants