Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: redesign cluster match map #2437

Merged
merged 11 commits into from
Jul 3, 2023

Conversation

lixun910
Copy link
Member

@lixun910 lixun910 commented Jun 12, 2023

  • Redesign logic:

    • Select in origin cluster, create selection variable (0-1)
    • Multiply selection variable with cluster indicator of target cluster
    • Make unique values map for the classifications that overlap, but use the correct color from the original cluster map of the target cluster (not the usual classification by size colors)
  • Redesign Cluster Match Map Setting

    • Input:
      • Select Origin Cluster Indicator
      • Select Target Cluster Indicator
        • Should be same drop down list as for origin
      • Select Clusters to Compare
        • Default should be none checked, instead of all checked
    • Remove parameters but keep save common cluster in field (this is the field shown on the map)

@lixun910 lixun910 self-assigned this Jun 12, 2023
@lixun910 lixun910 force-pushed the enh-redesign-cluster-match-map branch from 74b171c to 6f538cd Compare June 12, 2023 23:10
update the logic to filter the common clusters by using selected origin cluster(s)
@lixun910
Copy link
Member Author

@lanselin the new build could be found at: https://github.com/lixun910/geoda/actions/runs/5281989704 Let me know any questions or issues. Thanks!

There is a screenshot of the redesigned cluster match map
Screenshot 2023-06-15 at 2 01 35 PM

Since the value 0 could be used as a cluster identifier, so we use empty values for any non-matched observations instead:
Screenshot 2023-06-15 at 10 32 27 AM

@lixun910 lixun910 requested a review from lanselin June 15, 2023 22:35
@lixun910
Copy link
Member Author

Hi Luc, @lanselin please find the new build at: https://github.com/lixun910/geoda/actions/runs/5318749030

  • Fix the label "undefined" to "unmatched".
  • Fix the right unique value color scheme been applied to the filtered matched clusters (see the two screenshots below)

Before: see the red highlighted results -- we can't simply apply filtering on the target clusters since the number of matched clusters differs from the target clusters. Therefore, we also need to remember the color scheme of the target clusters and apply it on the cluster match map (see the second screenshot)
Screenshot 2023-06-20 at 8 34 19 AM

After:
Screenshot 2023-06-19 at 10 12 41 PM

@lixun910 lixun910 merged commit 0edb506 into GeoDaCenter:master Jul 3, 2023
@lixun910 lixun910 deleted the enh-redesign-cluster-match-map branch July 3, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant