Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #303 add fallback type nominatim #304

Merged
merged 3 commits into from
Oct 17, 2021
Merged

Conversation

BilelJegham
Copy link
Member

@BilelJegham BilelJegham commented Oct 14, 2021

Close #303

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #304 (c5d5c5e) into master (643a0bd) will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   41.12%   41.52%   +0.39%     
==========================================
  Files          43       43              
  Lines        1347     1351       +4     
  Branches      260      262       +2     
==========================================
+ Hits          554      561       +7     
+ Misses        768      765       -3     
  Partials       25       25              
Impacted Files Coverage Δ
src/utils/index.js 72.09% <100.00%> (+5.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643a0bd...c5d5c5e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BilelJegham BilelJegham merged commit dcc5027 into master Oct 17, 2021
@BilelJegham BilelJegham deleted the feature/#303-add_fallback branch October 17, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add fallback in AreasModeObject - Mexico city not states
1 participant