Add reusable ESLint workflow. #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runs the eslint defined in the given package.json, configured by the associated eslint.config.mjs file.
wilsonjord
reviewed
Jun 12, 2024
Comment on lines
23
to
27
| if [ -n "${{ inputs.paths }}" ]; then | ||
| echo "paths=$(echo '${{ inputs.paths }}' | tr '\n' ' ')" >> $GITHUB_OUTPUT | ||
| else | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
issue: the if statement not needed, as you have paths: required: true in the inputs.
question: is this step even required at all?
| env: | ||
| PATHS: ${{ steps.parse-paths.outputs.paths }} | ||
| run: | | ||
| echo "$PATHS" | tr ' ' '\n' | xargs -I '{}' -n 1 sh -c 'ESLINT_USE_FLAT_CONFIG=true $1/node_modules/.bin/eslint -c $1/eslint.config.mjs "$1"' _ '{}' |
There was a problem hiding this comment.
suggestion: I think making this step work directly with ${{ inputs.paths }} might be worthwhile, maybe utilising bash's for loop automatically splitting by space, tab, and newline...like
for path in $PATHS; do
do stuff
Removes complicated bash syntax
Now that it's using inputs.paths directly, don't need this parse step. Also, paths is required, so no need to check that paths have been given
wilsonjord
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.