Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds ability to create new task revisions, and optionally deploy #286

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

wilsonjord
Copy link
Contributor

@wilsonjord wilsonjord commented Jul 8, 2024

This PR adds a new workflow allowing for CICD-based deployments.
Typically, services using this workflow would be configured in Terraform (see https://github.com/GeoNet/terraform-aws/pull/1151).

Re: deployment generally, I see this as an option, not the option. I think Terraform-based deployments / Terraform-tracked explicit deployment tags can co-exist with CICD-based deployments.

@wilsonjord wilsonjord force-pushed the feature-deploy-workflow branch 4 times, most recently from e3c1dad to 1075946 Compare July 8, 2024 22:03
@wilsonjord wilsonjord marked this pull request as ready for review July 8, 2024 22:36
@wilsonjord wilsonjord requested review from ozym, MCorfy and Mossman1215 July 8, 2024 22:44
@wilsonjord wilsonjord self-assigned this Jul 8, 2024
@wilsonjord wilsonjord added the enhancement New feature or request label Jul 8, 2024
@wilsonjord wilsonjord requested a review from CallumNZ July 15, 2024 02:19
Copy link
Contributor

@CallumNZ CallumNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'm not familiar with EventBridge or System Store parameters so need to read up to know exactly what's going on there.

Comment on lines 25 to 29
rule-name:
required: false
type: string
description: |
name of rule to update, if deploying
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not immediately clear what this is.

Comment on lines 30 to 39
container:
required: false
type: string
description: |
name of container
task-name:
required: false
type: string
description: |
name of task definition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these need a , if deploying caveat on the description like the others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, task name / container is always required, so I'll update it to required: true

Comment on lines 40 to 45
skip-workflow:
required: false
type: boolean
default: false
description: |
skip this workflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, will remove (it's a relic from the past)

.github/workflows/reusable-aws-deploy.yml Show resolved Hide resolved
type of deployment, valid values are
ecs, eventbridge, or empty for no deployment
deployment-tag-param-name:
required: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if deploying but this is left blank?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The param will have either the value of Null, or the previous deployment information.
On the next terraform apply, the container tag will be latest, or the previously deployed container, respectively.

README.md Outdated
@@ -1117,6 +1118,92 @@ jobs:
```


### AWS deploy

STATUS: stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bold move.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps premature. I had intended it to signify I don't expect any breaking changes to occur, once this is in production. I will mark as Beta: I consider it complete and ready to be declared as stable, subject to public testing.

@wilsonjord wilsonjord force-pushed the feature-deploy-workflow branch 2 times, most recently from 8c964c0 to da938f5 Compare July 18, 2024 02:21
Allows a workflow to update a task definition with updated container,
and deploy new task revision.
@wilsonjord wilsonjord force-pushed the feature-deploy-workflow branch from da938f5 to f0bf4c5 Compare July 18, 2024 02:22
@wilsonjord wilsonjord requested a review from CallumNZ July 18, 2024 02:31
Copy link
Contributor

@CallumNZ CallumNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wilsonjord wilsonjord merged commit e529ef2 into main Jul 19, 2024
16 checks passed
@wilsonjord wilsonjord deleted the feature-deploy-workflow branch July 19, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants