Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove duplicate manual collect entries from sites.csv #2000

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

elidana
Copy link
Contributor

@elidana elidana commented Mar 14, 2024

Hi @ozym and @rumachan ,

this complete the separation of manually collected data from seismic stations metadata tables in delta.
All entries that I have removed here from sites.csv are present and the same in points.csv

I have tested this locally and

  • all tests are passing
  • tilde configuration files generated from this pull request and the main delta branch are the same

@elidana elidana requested a review from rumachan March 14, 2024 20:55
@elidana elidana requested review from ozym and a team as code owners March 14, 2024 20:55
ozym
ozym previously approved these changes Mar 14, 2024
Copy link
Contributor

@ozym ozym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but I didn't check all.

@elidana
Copy link
Contributor Author

elidana commented Mar 20, 2024

hi @rumachan , i've fixed conflicts and updated this pr, that is now ready to be meged. can i please have another thumbsup? thanks!

@elidana elidana merged commit 1d3547b into GeoNet:main Mar 21, 2024
9 checks passed
@elidana elidana deleted the move-manualcollect branch March 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants