Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use default credentials for keyspaces #149

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

CallumNZ
Copy link
Contributor

Reference: https://github.com/GeoNet/tickets/issues/12494

Change to allow aws roles for authentication to Keyspaces.

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@CallumNZ CallumNZ requested a review from wilsonjord November 15, 2023 23:55
Copy link
Contributor

@wilsonjord wilsonjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: seems like it's replacing one style of authenication (with KEYSPACE_* variables set), with one based on AWS roles...assume risk of loads of code being broken is small?

@CallumNZ
Copy link
Contributor Author

tilde-ws and tilde-meta are the only ones that use it.
I'll be updating their respective terraform/code after grabbing the new version of kit.

@wilsonjord
Copy link
Contributor

Cool thanks. Well, this PR looks good. Incidentally, I'll also be working on kit updates which may be "breaking". Perhaps a future discussion on versioning might be handy.

@sue-h-gns sue-h-gns merged commit 733144a into main Nov 16, 2023
5 checks passed
@sue-h-gns sue-h-gns deleted the keyspaceCredsUpdate branch November 16, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants