Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vendor files #161

Merged
merged 1 commit into from
Mar 7, 2024
Merged

chore: remove vendor files #161

merged 1 commit into from
Mar 7, 2024

Conversation

junghao
Copy link
Contributor

@junghao junghao commented Mar 7, 2024

Proposed Changes

Seems that we accidentally added vendor into kit (kit/vendor was added last Nov).
With vendor under kit, will cause issues when downstream doing go mod tidy then go vendor, which resulted the application's vendors are copied from kit/vendor instead of fetch from source, which is not desired.

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@sue-h-gns sue-h-gns merged commit 7386d05 into main Mar 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants