chore: update aws sdk, also for all the dependencies #162
Conversation
junghao
force-pushed
the
aws-deps
branch
5 times, most recently
from
8c68af4 to
aad6638
Compare
aws/s3/s3.go
Outdated
| @@ -243,7 +243,7 @@ func (s *S3) GetContentSizeTime(bucket, key string) (int64, time.Time, error) { | |||
| if err != nil { | |||
| return size, mt, err | |||
| } | |||
| return o.ContentLength, *o.LastModified, nil | |||
| return *o.ContentLength, *o.LastModified, nil | |||
There was a problem hiding this comment.
should probably use aws.ToString() / aws.String() (can't remember which in this case). Is safer if pointer is nil.
Probably review all the pointers in this PR.
There was a problem hiding this comment.
This is AWS SDK changed the member type in the returned structure from int64 to *int64, not the calling parameters.
And the reason I didn't do pointer check is because the *o.LastModified has been living well, also there's already a error check right above, and apparently the ContentLength is not an optional attribute. So I think it should be fine to just de-referencing it.
There was a problem hiding this comment.
Also for the IsTruncated below, I don't think it's optional tool. It must have zero value when the sdk forms the structure.
Proposed Changes
aws wrappers in kit is working weirdly due to aws sdk version conflicts with downstream application's dependencies.
eg.
fitsrequires go-aws-sdk-v2 v1.25 and above, however existin go-aws-sdk-v2 in kit is v1.22.This caused a conflict between data types (aws has changed some functions' signatures to pointer)
Also did a full upgrade for all other dependencies. Hope I'm doing what we supposed to do?
Please note the upgraded dependencies here https://github.com/GeoNet/kit/pull/162/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R6
(I don't think we can care about those indirect)
Production Changes
The following production changes are required to deploy these changes:
Review
Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.
Code Review Guide
Insert check list here if needed.