Implement XmlFilehandler

[etj]

Is your feature request related to a problem? Please describe.

As per GeoNode/geonode#11448 (Errors in metadata upload), the upload of a metadata file is broken since GeoNode/geonode#11363.

Describe the solution you'd like

We need a new handler for the metadata XML files.

[ridoo]

@mattiagiupponi as this issue is quite important for thuenen, would it be possible to create a patch release which includes this fix?

What is your opinion on an early integration? Would it make sense only, after the geonode part have been improved?

[mattiagiupponi]

Hi @ridoo
This is not yet fully ready. I am going to merge #203 which refactors the handler. We also need to fix the geoserver-restconfig lib before the merge.

What is your opinion on an early integration? Would it make sense only, after the geonode part has been improved?

If you want to upload XML and SLD files via API and track their status, it is possible to use it even if the front-end part is not yet ready. The API accepts the same parameters as the ones sent by the front end. the dataset_title in the request.data is necessary to identify the dataset.

However, if you intend to allow the user to upload data through the user interface, it's better to wait until the front-end issue is resolved before proceeding. This is because even if the handlers are triggered, the user won't receive any feedback on their completion.

@mattiagiupponi as this issue is quite important for thuenen, would it be possible to create a patch release which includes this fix?

I'll sync with @giohappy when everything is ready and i'll let you know

[ridoo]

Thanks @mattiagiupponi for the clarification!

[mattiagiupponi]

Hi @ridoo
Both handlers (xml and sld) are merged, i refactored them a bit since they have a common structure.
The UI is not planned for the short time i guess, but they can be used via the upload API mimic the actual XML/SLD upload

[gannebamm]

@mattiagiupponi thanks for the info. Will the xml be used if I upload a dataset with xml file? The planned UI is for the metadata xml upload for an already existing dataset?

[mattiagiupponi]

@mattiagiupponi thanks for the info. Will the xml be used if I upload a dataset with xml file?

If spatial files are uploaded along with other files, the spatial handler will handle both the files.
For example in the BaseVectorFileHandler during the resource creation in geonode

geonode-importer/importer/handlers/common/vector.py

Lines 607 to 608 in b2b038c

	self.handle_xml_file(saved_dataset, _exec)
	self.handle_sld_file(saved_dataset, _exec)

The handler check if the files exists and use them

The planned UI is for the metadata xml upload for an already existing dataset?

Yes, thats why we had to create this two handlers, are used only during the upload for a pre-existing dataset.

Let me know if is clear or some additional detail are needed :)