Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #10474] enable geonode-importer by default #10996

Merged
merged 22 commits into from
May 12, 2023
Merged

[Fixes #10474] enable geonode-importer by default #10996

merged 22 commits into from
May 12, 2023

Conversation

mattiagiupponi
Copy link
Contributor

ref #10474
Geonode importer enabled by default

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@mattiagiupponi mattiagiupponi self-assigned this May 2, 2023
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label May 2, 2023
giohappy
giohappy previously approved these changes May 2, 2023
@mattiagiupponi mattiagiupponi marked this pull request as draft May 3, 2023 13:41
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #10996 (b70c536) into master (a62c954) will decrease coverage by 1.52%.
The diff coverage is 58.69%.

❗ Current head b70c536 differs from pull request most recent head d90d089. Consider uploading reports for the commit d90d089 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10996      +/-   ##
==========================================
- Coverage   62.41%   60.89%   -1.52%     
==========================================
  Files         828      828              
  Lines       51578    51153     -425     
  Branches     6606     6560      -46     
==========================================
- Hits        32192    31151    -1041     
- Misses      17677    18483     +806     
+ Partials     1709     1519     -190     

@mattiagiupponi mattiagiupponi marked this pull request as ready for review May 4, 2023 16:21
@mattiagiupponi mattiagiupponi requested a review from giohappy May 4, 2023 16:21
@giohappy giohappy merged commit c5619bf into master May 12, 2023
@giohappy giohappy deleted the ISSUE_10474 branch May 12, 2023 14:30
ridoo pushed a commit to Thuenen-GeoNode-Development/geonode that referenced this pull request Jun 2, 2023
* [Fixes GeoNode#10474] enable geonode-importer by default

* [Fixes GeoNode#10474] enable geonode-importer by default

* [Fixes GeoNode#10474] fix importlayers

* [Fixes GeoNode#10474] fix importlayers

* [Fixes GeoNode#10474] fix importlayers

* [Fixes GeoNode#10474] fix importlayers

* [Fixes GeoNode#10474] fix importlayers

* [Fixes GeoNode#10474] fix tests

* [Fixes GeoNode#10474] fix tests

* [Fixes GeoNode#10474] fix tests

* [Fixes GeoNode#10474] fix tests

* [Fixes GeoNode#10474] fix tests

* add logger for publishing

* test fix

* test fix

* Test removed since is no longer needed

* fix requirements

* remove unwanted change in the settings file

---------

Co-authored-by: Alessio Fabiani <alessio.fabiani@geosolutionsgroup.com>
Co-authored-by: Giovanni Allegri <giohappy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants