Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11821] GNIP 98: Django upgrade to 4.2 LTS #11829

Merged
merged 59 commits into from
Jan 31, 2024
Merged

[Fixes #11821] GNIP 98: Django upgrade to 4.2 LTS #11829

merged 59 commits into from
Jan 31, 2024

Conversation

mattiagiupponi
Copy link
Contributor

@mattiagiupponi mattiagiupponi commented Jan 10, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 10, 2024
@mattiagiupponi mattiagiupponi changed the title Issue 11821 [Fixes #11821] GNIP 98: Django upgrade to 4.2 LTS Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #11829 (608c6f7) into master (4bc8e5f) will increase coverage by 0.29%.
The diff coverage is 88.70%.

❗ Current head 608c6f7 differs from pull request most recent head 315c2c1. Consider uploading reports for the commit 315c2c1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11829      +/-   ##
==========================================
+ Coverage   63.04%   63.33%   +0.29%     
==========================================
  Files         877      864      -13     
  Lines       52655    52163     -492     
  Branches     6616     6559      -57     
==========================================
- Hits        33198    33040     -158     
+ Misses      17937    17615     -322     
+ Partials     1520     1508      -12     

@mattiagiupponi mattiagiupponi linked an issue Jan 12, 2024 that may be closed by this pull request
5 tasks
@mattiagiupponi mattiagiupponi marked this pull request as ready for review January 31, 2024 08:44
@mattiagiupponi mattiagiupponi removed this from the 4.3.0 milestone Jan 31, 2024
@mattiagiupponi mattiagiupponi mentioned this pull request Jan 31, 2024
12 tasks
@giohappy giohappy merged commit ab14ce6 into master Jan 31, 2024
9 of 15 checks passed
@giohappy giohappy deleted the ISSUE_11821 branch January 31, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNIP 98: Django upgrade to 4.2 LTS
2 participants