Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11992] Transfer users API under people app #11997

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

RegisSinjari
Copy link
Contributor

@RegisSinjari RegisSinjari commented Feb 27, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@RegisSinjari RegisSinjari self-assigned this Feb 27, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #11997 (738ddc9) into master (6ac1fe8) will increase coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 88.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11997      +/-   ##
==========================================
+ Coverage   63.61%   63.62%   +0.01%     
==========================================
  Files         866      866              
  Lines       52569    52584      +15     
  Branches     6600     6600              
==========================================
+ Hits        33440    33455      +15     
  Misses      17610    17610              
  Partials     1519     1519              

@RegisSinjari RegisSinjari linked an issue Feb 27, 2024 that may be closed by this pull request
@mattiagiupponi mattiagiupponi marked this pull request as ready for review February 27, 2024 09:01
Copy link
Contributor

@mattiagiupponi mattiagiupponi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RegisSinjari It looks like the URL of the API is different from the previous one:
The current ROOT api call return this payload

{
    "categories": "http://localhost:8000/api/v2/categories",
    "datasets": "http://localhost:8000/api/v2/datasets",
    "documents": "http://localhost:8000/api/v2/documents",
    "executionrequest": "http://localhost:8000/api/v2/executionrequest",
    "geoapps": "http://localhost:8000/api/v2/geoapps",
    "groups": "http://localhost:8000/api/v2/groups",
    "keywords": "http://localhost:8000/api/v2/keywords",
    "maps": "http://localhost:8000/api/v2/maps",
    "owners": "http://localhost:8000/api/v2/owners",
    "regions": "http://localhost:8000/api/v2/regions",
    "resources": "http://localhost:8000/api/v2/resources",
    "tkeywords": "http://localhost:8000/api/v2/tkeywords",
    "upload-parallelism-limits": "http://localhost:8000/api/v2/upload-parallelism-limits",
    "upload-size-limits": "http://localhost:8000/api/v2/upload-size-limits",
    "uploads": "http://localhost:8000/api/v2/uploads",
    "users": "http://localhost:8000/people/users" //<------------ this is wrong
}

and as you can see, the url is not the same as before.

In the issue was mentioned:

The current API will work the same and with the same URL.

Only the code should be moved, the URL should stay the same as before

@mattiagiupponi mattiagiupponi self-requested a review February 27, 2024 10:40
@mattiagiupponi mattiagiupponi merged commit bba6bdb into master Feb 27, 2024
17 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_11992 branch February 27, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer users API under people app
2 participants