Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #11995] Implement the DELETE method for the User API #12028

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

RegisSinjari
Copy link
Contributor

@RegisSinjari RegisSinjari commented Mar 8, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@RegisSinjari RegisSinjari self-assigned this Mar 8, 2024
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Merging #12028 (dad23ee) into ISSUE_11995 (a411232) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           ISSUE_11995   #12028      +/-   ##
===============================================
+ Coverage        63.80%   63.88%   +0.07%     
===============================================
  Files              867      867              
  Lines            52843    52934      +91     
  Branches          6609     6614       +5     
===============================================
+ Hits             33719    33815      +96     
+ Misses           17598    17594       -4     
+ Partials          1526     1525       -1     

@mattiagiupponi mattiagiupponi added this to the 4.3.0 milestone Mar 11, 2024
geonode/base/api/tests.py Outdated Show resolved Hide resolved
geonode/base/api/tests.py Outdated Show resolved Hide resolved
geonode/people/tests.py Outdated Show resolved Hide resolved
geonode/people/tests.py Show resolved Hide resolved
@RegisSinjari RegisSinjari marked this pull request as ready for review March 11, 2024 11:58
@mattiagiupponi mattiagiupponi merged commit f25e550 into ISSUE_11995 Mar 11, 2024
12 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_11995_2 branch March 11, 2024 14:31
giohappy added a commit that referenced this pull request Mar 21, 2024
…2072)

* [Fixes #11995 Implement POST and PATCH methods for the User API (#12011)

* [Fixes #11995] Implement POST and PATCH methods for the User API
* Upgrare Remote Docker for CircleCI
* [Fixes #11995] Implement POST and PATCH methods for the User API, refactored validation in serializer

---------

Co-authored-by: RegisSinjari <omilale2@gmail.com>
Co-authored-by: Giovanni Allegri <giohappy@gmail.com>

* [Fixes #11995] Implement the DELETE method for the User API (#12028)

* [Fixes #11995] Implement the DELETE method for the User API

* [Fixes #11995] Implement the DELETE method for the User API refactor and docstrings added

* [Fixes #11995] Implement endpoint to transfer resources (#12067)

* [Fixes #11995] Implement endpoint to transfer ownership

* [Issue 11995] Implement endpoint to unregister as a project manager (#12066)

* [FIXES #11995] Implement endpoint to unregister as a project manager

* [FIXES #11995] Implement endpoint to unregister as a project managergroup.group_id

* [FIXES #11995] Implement endpoint to unregister as a project manager,tests added

* [Fixes #11995] black reformatting

* [Fixes #11995] GNIP 99: Implement a CRUD REST API for users

* [Fixes #11995] GNIP 99: Implement a CRUD REST API for users

* Update views.py

---------

Co-authored-by: RegisSinjari <omilale2@gmail.com>
Co-authored-by: Giovanni Allegri <giohappy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants