Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12167] providing multiple openid_connect django.allauth socialproviders fails when loading login page #12169

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mwallschlaeger
Copy link
Member

@mwallschlaeger mwallschlaeger commented Apr 18, 2024

ref #12167, #12180

minor fix to allow mutiple APPS defined in an openid_connect , SOCIALACCOUNT_PROVIDERS. Further it includes check that client_id must be set.

closes #12167
closes #12180

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

…h socialproviders fails when loading login page
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Merging #12169 (6f5a2ca) into master (3d6ab6e) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12169   +/-   ##
=======================================
  Coverage   64.04%   64.04%           
=======================================
  Files         870      870           
  Lines       52178    52178           
  Branches     6483     6483           
=======================================
  Hits        33418    33418           
  Misses      17259    17259           
  Partials     1501     1501           

@mwallschlaeger mwallschlaeger marked this pull request as draft April 19, 2024 11:43
…h socialproviders fails when loading login page
@mwallschlaeger
Copy link
Member Author

mwallschlaeger commented Apr 23, 2024

I go to continue work on this PR trying to fix also: #12180

…h socialproviders fails when loading login page
…_#12167_providing_multiple_openid_connect_django_allauth_socialproviders_fails_when_loading_login_page
@mwallschlaeger
Copy link
Member Author

still in draft mode. There is still an issue connecting different openid_connect apps

@giohappy
Copy link
Contributor

@mwallschlaeger any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.2.x bug cla-signed CLA Bot: community license agreement signed configuration
Projects
None yet
2 participants