Skip to content

Reset password #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2012
Merged

Reset password #21

merged 2 commits into from
Feb 8, 2012

Conversation

jj0hns0n
Copy link
Contributor

@jj0hns0n jj0hns0n commented Mar 9, 2011

Implemented the reset password link

@dwins
Copy link
Contributor

dwins commented Jun 6, 2011

This probably needs a bit more work; even if I don't have a mail server configured this offers to send me a mail and doesn't even error when it fails to do so.

@jj0hns0n
Copy link
Contributor Author

This is standard django functionality. All my pull request is doing is linking this from the Login page. See here ... https://docs.djangoproject.com/en/dev/topics/auth/#django.contrib.auth.views.password_reset ... any suggestions as to what to actually do in the case of a missing email config are welcome, but they would likely require changes to django itself, unless we re-implement this same functionality on our own?

@sbenthall
Copy link
Contributor

@jj0hns0n
Copy link
Contributor Author

Seb, Im planning to get to that one here asap, but my strategy was
going to be to override the view, check if an email server was
configured, and if not, send them to a template that gave the
administrators email address and telling the user to contact the admin
via email. And if an email server was configured, just carry on
letting them reset.

Im not sure if the code in django-registration handles for when mails
are not sent successfully. I.e. the user expects a mail and may never
get one.

On Tue, Jul 12, 2011 at 2:12 PM, sbenthall
reply@reply.github.com
wrote:

I just made this StackOverflow post to address this question:

http://stackoverflow.com/questions/6671186/how-can-i-make-my-django-app-with-password-reset-fail-gracefully-when-email-is-no

Reply to this email directly or view it on GitHub:
#21 (comment)

@sbenthall
Copy link
Contributor

IMO, if StackO gives any answers, then it would be worth implementing them. Otherwise, I think it would be right to pull this in lest the perfect be the enemy of the good.

@dwins
Copy link
Contributor

dwins commented Jul 12, 2011

There's some relevant discussion on http://dev.geonode.org/trac/ticket/869

@ingenieroariel
Copy link
Member

There was an answer in:

http://stackoverflow.com/questions/6671186/how-can-i-make-my-django-app-with-password-reset-fail-gracefully-when-email-is-no

Basically said it is the admin's fault, not the user's.

@ingenieroariel
Copy link
Member

I am +1 on getting this one as is. There is the same problem with registration at the moment and instructions to set up the email gateway in the settings.

@dwins dwins merged commit ce91157 into GeoNode:master Feb 8, 2012
ahocevar pushed a commit to ahocevar/geonode that referenced this pull request Mar 26, 2013
travislbrundage pushed a commit to travislbrundage/geonode that referenced this pull request Mar 24, 2016
goudine pushed a commit to goudine/geonode that referenced this pull request Feb 1, 2018
marthamareal pushed a commit to marthamareal/geonode that referenced this pull request Sep 24, 2021
marthamareal pushed a commit to marthamareal/geonode that referenced this pull request Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants