-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements GNIP #3718 (Worldmap contrib application) #3817
Conversation
…ly build worldmap database
Removing certification app from GeoNode
[WIP] Dataverse and datatables migration
Add missing translations
Add extra metadata attributes
Hi @capooti great work thanks. Will test the PR ASAP on my side. Just few comments:
|
geonode/people/forms.py
Outdated
@@ -92,5 +93,6 @@ class Meta: | |||
'username', | |||
'is_staff', | |||
'is_superuser', | |||
'is_active', | |||
'date_joined') | |||
'is_active' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand why you removed a comma here. It looks to me a syntax error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for spotting it! I am not sure how this happened.
Codecov Report
@@ Coverage Diff @@
## 2.7.x #3817 +/- ##
==========================================
- Coverage 42.61% 42.56% -0.05%
==========================================
Files 257 261 +4
Lines 18092 18166 +74
Branches 2753 2760 +7
==========================================
+ Hits 7710 7733 +23
- Misses 9850 9898 +48
- Partials 532 535 +3
Continue to review full report at Codecov.
|
of multi-disciplinary, multi-source and multi-format data, | ||
organized spatially and temporally.</p> | ||
""" | ||
# these are optionals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there instructions and documentation on how to handle those optional settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I have added a page in the documentation:
https://github.com/GeoNode/geonode/blob/2.7.x/docs/reference/worldmap.txt
I will try to improve it as soon as possible.
thanks!
… application)
This PR adds the GeoNode contrib application in GeoNode.
It also include a few enhancements (like for example using u18n in a number of places)