-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #5419] [Fixes #5446] Hierarchical keyword tree widget issues #5444
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5444 +/- ##
===========================================
- Coverage 57.57% 29.14% -28.44%
===========================================
Files 172 172
Lines 19299 19299
Branches 3006 3006
===========================================
- Hits 11112 5625 -5487
- Misses 7167 13449 +6282
+ Partials 1020 225 -795 |
@t-book cool thanks! |
@t-book any chance to restore the deleted assets? The binary files I mean. |
Binaries are restored. I've opened a ticket for grunt ... |
@afabiani I'm closing here and will restart. After rethinking it I do not like removing the clean:lib task from grunt as my last commit did. ( In my opinion, a new build should rebuild all needed files and we should not end up with a directory where it's unclear which files are needed and which are obsolete. ) |
This Fix will solve #5419 by changing the styling of icons. (base.less introduced a left-margin which made the icons overlap) Further, it will fix #5446 (binary files removed from lib) therefore clean:lib has been removed. the /lib directory should stay as is and only replace new build files.
After applying, Hierarchical keyword will look like shown here
Layer list view
Wizard
Advanced Metadata editing
Next to less I've build the minified files and fixed a typo in docs.
Checklist
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):