Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #5419] [Fixes #5446] Hierarchical keyword tree widget issues #5444

Closed
wants to merge 6 commits into from

Conversation

t-book
Copy link
Contributor

@t-book t-book commented Dec 20, 2019

This Fix will solve #5419 by changing the styling of icons. (base.less introduced a left-margin which made the icons overlap) Further, it will fix #5446 (binary files removed from lib) therefore clean:lib has been removed. the /lib directory should stay as is and only replace new build files.

After applying, Hierarchical keyword will look like shown here

Layer list view

Bildschirmfoto 2019-12-20 um 16 08 43

Wizard

Bildschirmfoto 2019-12-20 um 16 09 08

Advanced Metadata editing

Bildschirmfoto 2019-12-20 um 16 09 41

Next to less I've build the minified files and fixed a typo in docs.

Checklist

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Dec 20, 2019
@t-book t-book self-assigned this Dec 20, 2019
@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #5444 into master will decrease coverage by 28.43%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5444       +/-   ##
===========================================
- Coverage   57.57%   29.14%   -28.44%     
===========================================
  Files         172      172               
  Lines       19299    19299               
  Branches     3006     3006               
===========================================
- Hits        11112     5625     -5487     
- Misses       7167    13449     +6282     
+ Partials     1020      225      -795

@afabiani
Copy link
Member

@t-book cool thanks!

@afabiani afabiani added this to the 2.10.2 milestone Dec 20, 2019
@afabiani
Copy link
Member

@t-book any chance to restore the deleted assets? The binary files I mean.

@t-book
Copy link
Contributor Author

t-book commented Dec 20, 2019

@t-book any chance to restore the deleted assets? The binary files I mean.

@afabiani

Yeah sure no problem. This must happen on grunt production. I will check why.

@t-book
Copy link
Contributor Author

t-book commented Dec 20, 2019

Binaries are restored. I've opened a ticket for grunt ...

@t-book t-book changed the title [Fixes #5419] Hierarchical keyword tree widget issues [Fixes #5419] [Fixes #5446] Hierarchical keyword tree widget issues Dec 22, 2019
@t-book
Copy link
Contributor Author

t-book commented Dec 22, 2019

@afabiani I'm closing here and will restart. After rethinking it I do not like removing the clean:lib task from grunt as my last commit did. ( In my opinion, a new build should rebuild all needed files and we should not end up with a directory where it's unclear which files are needed and which are obsolete. )

@t-book t-book closed this Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grunt production removes binary files
2 participants