Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #5801] Check User permissions for private group #6643

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Conversation

afabiani
Copy link
Member

@afabiani afabiani commented Nov 15, 2020

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@afabiani afabiani requested review from gannebamm and t-book November 15, 2020 09:32
@afabiani afabiani self-assigned this Nov 15, 2020
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Nov 15, 2020
@t-book
Copy link
Contributor

t-book commented Nov 15, 2020

thanks @afabiani looks good. I can test/checkout the PR tomorrow morning.

@afabiani
Copy link
Member Author

@t-book I'm going to add some test cases before considering this done

@afabiani afabiani marked this pull request as ready for review November 15, 2020 10:52
@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #6643 (bad3c87) into master (e1d986e) will increase coverage by 1.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6643      +/-   ##
==========================================
+ Coverage   57.99%   59.05%   +1.06%     
==========================================
  Files         188      188              
  Lines       21421    21427       +6     
  Branches     3574     3577       +3     
==========================================
+ Hits        12423    12654     +231     
+ Misses       7915     7653     -262     
- Partials     1083     1120      +37     

@afabiani afabiani force-pushed the master branch 8 times, most recently from 0f38a5d to 64762ef Compare November 16, 2020 01:06
@t-book
Copy link
Contributor

t-book commented Nov 16, 2020

@afabiani I've tested this PR and it works great! Thanks!

@afabiani afabiani force-pushed the master branch 7 times, most recently from 99d1636 to 6ea3992 Compare November 16, 2020 15:10
@afabiani afabiani merged commit 4f3c3ff into master Nov 16, 2020
@afabiani afabiani deleted the ISSUE_5801 branch November 16, 2020 15:20
github-actions bot pushed a commit that referenced this pull request Nov 16, 2020
* [Fixes #5801] Check User permissions for private group

* [Fixes #5801] Check User permissions for private group: tests

* [Fixes #5801] Check User permissions for private group: tests
afabiani pushed a commit that referenced this pull request Nov 16, 2020
* [Fixes #5801] Check User permissions for private group

* [Fixes #5801] Check User permissions for private group: tests

* [Fixes #5801] Check User permissions for private group: tests

Co-authored-by: Alessio Fabiani <alessio.fabiani@geo-solutions.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants