-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #5801] Check User permissions for private group #6643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks @afabiani looks good. I can test/checkout the PR tomorrow morning. |
@t-book I'm going to add some test cases before considering this done |
Codecov Report
@@ Coverage Diff @@
## master #6643 +/- ##
==========================================
+ Coverage 57.99% 59.05% +1.06%
==========================================
Files 188 188
Lines 21421 21427 +6
Branches 3574 3577 +3
==========================================
+ Hits 12423 12654 +231
+ Misses 7915 7653 -262
- Partials 1083 1120 +37 |
afabiani
force-pushed
the
master
branch
8 times, most recently
from
November 16, 2020 01:06
0f38a5d
to
64762ef
Compare
t-book
approved these changes
Nov 16, 2020
@afabiani I've tested this PR and it works great! Thanks! |
afabiani
force-pushed
the
master
branch
7 times, most recently
from
November 16, 2020 15:10
99d1636
to
6ea3992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.