-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIBW: add support for py3.10 and Apple Silicon; use CIBWv2 #211
Conversation
MuellerSeb
commented
Oct 11, 2021
•
edited
Loading
edited
- Add support for py3.10
- Add wheels for Apple Silicon
- split CI jobs per arch
- CIBW config in pyproject.toml
- update classifiers in setup.cfg
Guess we have to wait for py310 wheels from numpy and scipy to be released. |
I think most Raspberry Pis still run 32bit systems, if I'm not mistaken. I guess it is not very relevant, but it doesn't really hurt us at the moment to keep the 32bit wheels, so I vote for keeping them. |
Numpy v1.21.3 was released with prebuild wheels for python v3.10 on 64bit machines. Therefore I skipped 32bit wheels on python 3.10 for now. Unfortunately, we have to wait until Afterwards we have to see, if numpy adds wheels for 32bit (win+linux) for py310 and if |
FYI both NumPy and SciPy will not ship 32bits wheels anymore (py3.10 and above). |
Thanks for the Info! |
The Github actions still need to be updated.
@LSchueler do you have any clue on what manylinux version to use? For now I selected Before we were providing Also I didn't enable the So, remaining questions:
|
Good questions! And thank you for keeping everything up to date 👍
|
Now, the GSTools-Core is used, if the package can be imported, but it can also be switched off, by setting the global var. `gstools.config.USE_RUST=False` during the runtime.
This makes the Cython code compatible to GSTools-Core v0.1.2 again.
Add optional dependency GSTools-Core
Will do so.
Ok, so to keep brainwork low on our side, I would then just use the defaults of CIBuildwheel, which is
It didn't work, since Afterwards we should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, Py3.10 support!
I think a release of v1.3.4 makes sense now (the doc. for how to use GSTools-Core doesn't make a lot of sense without the release and now the support for py3.10). Or would you rather wait for the paper to get published?
@LSchueler when the CI succeeds, I would merge this. A 1.3.4 release would be just fine afterwards. Maybe we could wait for the missing wheels of GSTools-Core: GeoStat-Framework/GSTools-Core#15 |
I did a rebase to update the changelog. Guess this messed up the commits. Should be fine afterwards.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is really messed up! :-D
But yeah, I'm fine with it 👍
LGTM!