-
Notifications
You must be signed in to change notification settings - Fork 78
Add sum model #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sum model #364
Conversation
…operty to TPL models
…re derived from correlation not cor
…into add_sum_model
|
@LSchueler this is ready for review. |
|
Awesome, I'll need some time to thoroughly go throw your changes. |
|
First come, first serve :-D |
LSchueler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long to finish this review, but as you know, I had the best reasons ;-)
I'm really looking forward to sum models being integrated into GSTools, but I found quite a few things which should be addressed before merging.
|
@LSchueler fixed (almost) all your complains. Second look? 🙃 |
LSchueler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you especially for the changes in the documentation. I think the examples readme is a lot more interesting and convincing now!
I only found the same typo two or three times, but if that gets fixed, this is good to go 🎉
LGTM 🎉 |
This PR adds a
SumModelclass to represent sums of Covariance models.Sum-Model
SumModelclass+operator:model = m1 + m2m1 = model[0]model[0].nu == model.nu_0len_scaleis fixed, none of thelen_scale_<i>can be fixed since len_scale is calculated from variance ratioszero_varandmodelattributes to Generator ABC to shortcut field generation for pure nugget modelsOther changes
var_rawattribute from CovModel (was rarely used and only relevant for the truncated power law models)intensityattribute which calculates whatvar_rawwas beforevar_rawwas a bad idea in the first place)