Fully support Python version 3.8 again #389
Conversation
LSchueler
added
bug
| mesh_input = meshio.read("hexagon.mesh") | ||
| points = mesh_input.points | ||
| cells = mesh_input.cells[0].data | ||
| mesh = meshio.Mesh(points, {"triangle": cells}) |
There was a problem hiding this comment.
Isn't the mesh_input already a mesh? Why do we need to extract points and cells to create the mesh again?
There was a problem hiding this comment.
Their is a difference in the Mesh instance depending on whether it is read in from the "hexagon.mesh" file or created with meshzoo. The code breaks further down, because the cells are not as expected.
There was a problem hiding this comment.
Then I would prefer two files read with numpy (one for points[float], one for cells[int]) because this seems odd.
There was a problem hiding this comment.
That's a good idea, I just implemented that.
|
Pylint is failing because the config name for whitelisting in pyproject.toml changed:
|
|
Maybe we should finally switch to ruff for linting. |
As noted in PR #386, GSTools doesn't really support py3.8 at the moment due to changes in its dependencies. We have decided to keep supporting py3.8 for now and with this PR, I have fixed all dependency problems for py3.8 support.