Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeformatting with black #144

Merged
merged 9 commits into from
Mar 27, 2020
Merged

Codeformatting with black #144

merged 9 commits into from
Mar 27, 2020

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Mar 27, 2020

To be in line with the GeoStat-Framework standards, I reformatted the code base with black by executing:

black pykrige/

Also applied to docs, tests and examples.

Included minor updates:

  • include GSTools in tests
  • adopt GridSearchCV to be future prove
  • add black check stage in travis
  • update array comparison in tests to be future prove

@MuellerSeb MuellerSeb added this to the 1.5 milestone Mar 27, 2020
@MuellerSeb MuellerSeb self-assigned this Mar 27, 2020
@MuellerSeb MuellerSeb requested a review from rth March 27, 2020 17:13
Copy link
Contributor

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Might be worth adding a check to enforce this in CI,

black --check pykrige/ examples/ tests/

@MuellerSeb
Copy link
Member Author

MuellerSeb commented Mar 27, 2020

I updated travis and testing accordingly. When CI succeeds, I'll merge this.

@MuellerSeb MuellerSeb merged commit c9ccb05 into develop Mar 27, 2020
@MuellerSeb MuellerSeb deleted the black branch March 27, 2020 20:37
@MuellerSeb MuellerSeb mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants