Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue 224 #225

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fixed issue 224 #225

merged 1 commit into from
Nov 28, 2023

Conversation

DanielJDufour
Copy link
Member

Type of PR

  • Bug Fix

What is the Goal of the PR?

fix issue #224

What is the Motivation for the PR?

What Tests are Included?

Test called "issue #224" in stats.test.js

Copy link

@twelch twelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, lgtm

bbox: [xmin.toString(), ymin.toString(), xmax.toString(), ymax.toString()],
debug: false,
origin: [georaster.xmin.toString(), georaster.ymax.toString()],
overflow: false,
padding: ["1", "1"], // add a little padding in case the geometry is smaller than half a pixel
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this always apply 1 pixel padding then? It makes sense

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, it'll add 1 pixel padding all around, so technically 2 new pixels along the horizontal axis and 2 along the vertical axis. if the geometry is really small and the original width is 0 pixels, the new width will be 2 pixels.

it won't solve the issue of trying to grab values when a geometry is a lot smaller than a pixel size, but my thinking is that it'll be one piece in that solution

@DanielJDufour DanielJDufour merged commit e666ebf into master Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants