Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check in rebuilt parser #1

Closed
wants to merge 1 commit into from
Closed

Check in rebuilt parser #1

wants to merge 1 commit into from

Conversation

JimPanic
Copy link
Collaborator

After a few runs of bin/cake build and bin/cake build:parser, the tests
run through for import.

This commit is what changed.

Check in rebuilt parser
64154ed 
After a few runs of ``bin/cake build`` and ``bin/cake build:parser``, the tests
run through for ``import``.

This commit is what changed.
@GeoffreyBooth
Copy link
Owner

I’m thinking we should avoid committing the files in lib until the end, when we’re ready to submit a PR. That whole folder should really be in .gitignore, as it’s just compiled output. Those files will change with every commit, so committing them will make our commits really large and more complicated than necessary to sort through.

@JimPanic
Copy link
Collaborator Author

JimPanic commented Jul 27, 2016 via email

@GeoffreyBooth GeoffreyBooth deleted the rebuilt-parser branch August 2, 2016 06:33
GeoffreyBooth added a commit that referenced this pull request Aug 31, 2016
@GeoffreyBooth
Pull request attempt #1! Here goes nothing . . .
eb52daf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimPanic @GeoffreyBooth