Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists changed #345

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Anushkaagrawal22
Copy link

No description provided.

@Anushkaagrawal22
Copy link
Author

This pull request is from my develop branch which is same as your develop branch plus the changes i have made. Can you please review.

Copy link
Contributor

@vfisikop vfisikop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds CMAKE_MINIMUM_REQUIRED(VERSION 3.10) but there is CMAKE_MINIMUM_REQUIRED(VERSION 3.11) a few lines later in the file that should be removed.

@vfisikop vfisikop closed this Feb 14, 2025
@vfisikop vfisikop reopened this Feb 14, 2025
@Anushkaagrawal22
Copy link
Author

This PR adds CMAKE_MINIMUM_REQUIRED(VERSION 3.10) but there is CMAKE_MINIMUM_REQUIRED(VERSION 3.11) a few lines later in the file that should be removed.

I'll remove that CMAKE and will create pr again

@vissarion
Copy link
Member

No, please do not create more PRs! Just update this one.

@Anushkaagrawal22
Copy link
Author

No, please do not create more PRs! Just update this one.

okk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants