Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dying on bedrock does not generate a gravestone #22

Open
borkmaster12 opened this issue Feb 7, 2021 · 9 comments
Open

[BUG] Dying on bedrock does not generate a gravestone #22

borkmaster12 opened this issue Feb 7, 2021 · 9 comments

Comments

@borkmaster12
Copy link

Minecraft version: 1.16.5
Mod version: 1.7
Loaded Mods: Fabric API, Gravestones

Issue behavior:
Dying in any way on a bedrock block at any Y-level does not generate a gravestone. Replacing even the lowest level block of bedrock with any other block (such as stone), and dying on that block generates a gravestone. Placing a piece of bedrock at Y-64 and dying on it does not generate a gravestone.

@Guitsou
Copy link

Guitsou commented Apr 18, 2021

Minecraft version : 1.16.5
Mod version : 1.9

Same issue, dying on the roof of the nether two times. You can find your head, but not the grave.

@Hyperbean18
Copy link

Having the same problem, the mod doesn't even print the death coordinates

@mbg615
Copy link

mbg615 commented Jun 28, 2021

Minecraft Version : 1.16.5
Mod Version : 1.9
Other Mods : Fabric API 0.34.0

Grave does not generate in any dimension (Overworld / Nether / End) if the player died over bedrock.

@Flyvee
Copy link

Flyvee commented Aug 5, 2021

I've seen that you have blacklisted the bedrock block as a block that stops a grave from spawning. This has made building farms on top of the nether roof extremely dangerous because as the mod stops the grave from spawning, it then deletes all the items the player had with them instead of dropping the items on the bedrock instead.

@Guitsou
Copy link

Guitsou commented Aug 10, 2021

I've seen that you have blacklisted the bedrock block as a block that stops a grave from spawning. This has made building farms on top of the nether roof extremely dangerous because as the mod stops the grave from spawning, it then deletes all the items the player had with them instead of dropping the items on the bedrock instead.

Hi Flyvee,

Did you see a way to fix it?

@Flyvee
Copy link

Flyvee commented Aug 10, 2021

I've seen that you have blacklisted the bedrock block as a block that stops a grave from spawning. This has made building farms on top of the nether roof extremely dangerous because as the mod stops the grave from spawning, it then deletes all the items the player had with them instead of dropping the items on the bedrock instead.

Hi Flyvee,

Did you see a way to fix it?

There is a line in the code under Gravestones/src/main/java/net/guavy/gravestones/Gravestones.java in the last function that blacklists bedrock as a block for a grave to spawn on so by either deleting that line or by replacing it with an unused block like jigsaw or command block and the issue will be gone but when I've tried to compile the code myself, I've run into too many issues as the mod is outdated and many of the libraries it depends on, either uses a newer java version or has changed web locations, the web locations I could fix, but the java version I couldn't.

@Guitsou
Copy link

Guitsou commented Aug 11, 2021

I've seen that you have blacklisted the bedrock block as a block that stops a grave from spawning. This has made building farms on top of the nether roof extremely dangerous because as the mod stops the grave from spawning, it then deletes all the items the player had with them instead of dropping the items on the bedrock instead.

Hi Flyvee,
Did you see a way to fix it?

There is a line in the code under Gravestones/src/main/java/net/guavy/gravestones/Gravestones.java in the last function that blacklists bedrock as a block for a grave to spawn on so by either deleting that line or by replacing it with an unused block like jigsaw or command block and the issue will be gone but when I've tried to compile the code myself, I've run into too many issues as the mod is outdated and many of the libraries it depends on, either uses a newer java version or has changed web locations, the web locations I could fix, but the java version I couldn't.

Thank you for your answer ! I will try to find another mod... I have a lot of nether roof farms : too dangerous !

@Flyvee
Copy link

Flyvee commented Aug 11, 2021

I've seen that you have blacklisted the bedrock block as a block that stops a grave from spawning. This has made building farms on top of the nether roof extremely dangerous because as the mod stops the grave from spawning, it then deletes all the items the player had with them instead of dropping the items on the bedrock instead.

Hi Flyvee,
Did you see a way to fix it?

There is a line in the code under Gravestones/src/main/java/net/guavy/gravestones/Gravestones.java in the last function that blacklists bedrock as a block for a grave to spawn on so by either deleting that line or by replacing it with an unused block like jigsaw or command block and the issue will be gone but when I've tried to compile the code myself, I've run into too many issues as the mod is outdated and many of the libraries it depends on, either uses a newer java version or has changed web locations, the web locations I could fix, but the java version I couldn't.

Thank you for your answer ! I will try to find another mod... I have a lot of nether roof farms : too dangerous !

Let me know if you find one cause at best for fabric, the alternative is the grave datapack.

@kilroythethird
Copy link

Still an issue which is really sad since its an awesome mod but this single issue makes it almost useless for me since i simply cant trust it when mining on bedrock level (which i do a lot).
@Geometrically Any chance you can address this issue ?

PTOM76 added a commit to PTOM76/Gravestones that referenced this issue Jul 3, 2022
Geometrically pushed a commit that referenced this issue Nov 16, 2022
* Port to 1.18.2
Fixed an issue whereModMenu add-ons could not be accessed

* Port to 1.19

* Port to 1.19

* format code

* Port to 1.19

* Fix Dying on bedrock does not generate a gravestone

* #22 Fix Dying on bedrock does not generate a gravestone

* placed check

* dropAll by break
Geometrically pushed a commit that referenced this issue Jun 1, 2023
* Port to 1.18.2
Fixed an issue whereModMenu add-ons could not be accessed

* Port to 1.19

* Port to 1.19

* format code

* Port to 1.19

* Fix Dying on bedrock does not generate a gravestone

* #22 Fix Dying on bedrock does not generate a gravestone

* placed check

* dropAll by break

* Port to 1.19.3

* Port to 1.19.3

* Port to 1.19.3

* Port to 1.19.3

* Port to 1.19.3

* Port to 1.19.3

* gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants