Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MediaViewer): improvements #380

Merged
merged 11 commits into from
Jul 17, 2023
Merged

feat(MediaViewer): improvements #380

merged 11 commits into from
Jul 17, 2023

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Jul 14, 2023

  • More natural zooming on images with uncommon aspect ratios (/ dont jump-cut to zoomed version on first step)
  • Increase button sizes to match Loupe
  • Pinching shouldn't append to current size but rather the initial one
  • Spinner while image is loading now has a background
  • Rethink the way zoom works - instead of having a "scale", (ab)use the scrolled window's adjustments to figure out the sizes, whether it can zoom etc
  • Double click zoom in/out
  • Allow not expanding picture by default in media viewer

fix: #264
fix: #369
fix: #378

@GeopJr GeopJr marked this pull request as ready for review July 17, 2023 17:22
@GeopJr GeopJr merged commit 5053bc2 into main Jul 17, 2023
5 checks passed
@GeopJr GeopJr deleted the feat/media_viewer/improvements branch July 17, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant