Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis fails #834

Closed
rmichaelis opened this issue Aug 27, 2015 · 11 comments
Closed

travis fails #834

rmichaelis opened this issue Aug 27, 2015 · 11 comments

Comments

@rmichaelis
Copy link
Contributor

Has something changed ?

ERR! compile /home/travis/build/Geoportail-Luxembourg/geoportailv3/geoportailv3/static/js/search/searchdirective.js:528: ERROR - actual parameter 2 of ngeoCreateGeoJSONBloodhound does not match formal parameter
ERR! compile found : (null|ol.proj.Projection)
ERR! compile required: (function ((GeoJSONFeature|null)): boolean|undefined)
ERR! compile var bloodhound = ngeoCreateGeoJSONBloodhound(url, ol.proj.get('EPSG:3857'));
ERR! compile ^
ERR! compile
ERR! compile
ERR! compile 1 error(s), 0 warning(s), 97.3% typed
ERR! compile
ERR! closure-util Process exited with non-zero status, see log for more detail: 1

@petzlux
Copy link
Contributor

petzlux commented Aug 27, 2015

I think @elemoine changed search in ngeo , maybe try with update-node-modules ?

@petzlux
Copy link
Contributor

petzlux commented Aug 27, 2015

#817 ?

@rmichaelis
Copy link
Contributor Author

Are node modules not automatically updated in Travis ?

@petzlux
Copy link
Contributor

petzlux commented Aug 27, 2015

dont know about travis, did it work in your build?

@rmichaelis
Copy link
Contributor Author

I don't know... I don't want to break my build :-)

@petzlux
Copy link
Contributor

petzlux commented Aug 27, 2015

im trying with your branch as we speak ...

@petzlux
Copy link
Contributor

petzlux commented Aug 27, 2015

Unfortunately, yes get the same problem :-(

./node_modules/openlayers/node_modules/.bin/closure-util build build.json .build/build.js
info closure-util Reading build config
info closure-util Getting Closure dependencies
info closure-util Compiling 431 sources
ERR! compile /home/wepa/geoportailv3/geoportailv3/static/js/search/searchdirective.js:531: ERROR - actual parameter 2 of ngeoCreateGeoJSONBloodhound does not match formal parameter
ERR! compile found   : (null|ol.proj.Projection)
ERR! compile required: (function ((GeoJSONFeature|null)): boolean|undefined)
ERR! compile   var bloodhound = ngeoCreateGeoJSONBloodhound(url, ol.proj.get('EPSG:3857'));
ERR! compile                                                     ^
ERR! compile
ERR! compile 1 error(s), 0 warning(s),
ERR! compile 97.3% typed
ERR! compile
ERR! closure-util Process exited with non-zero status, see log for more detail: 1
make: *** [.build/build.js] Error 1

@petzlux
Copy link
Contributor

petzlux commented Aug 27, 2015

I think I found the issue , ngeo bloodhound function changed
https://github.com/camptocamp/ngeo/blob/master/src/services/creategeojsonbloodhound.js#L10

Will create pull request to change!

@petzlux
Copy link
Contributor

petzlux commented Aug 27, 2015

@rmichaelis use #835 to fix problem.

@petzlux
Copy link
Contributor

petzlux commented Aug 27, 2015

okay @rmichaelis , if you rebase from master , then problem should be gone at next build

@rmichaelis
Copy link
Contributor Author

It works. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants