-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use typeahead.js 0.11.1 #817
Conversation
5abb82b
to
a92712a
Compare
@petzlux, could you please test this? |
@elemoine sorry but after a No error messages either in debug mode |
Strange. What if you do a local search (layers)? Is your instance available on devv3 so I can test it myself? Thanks for testing. |
I need to merge camptocamp/ngeo#283 as soon as possible, as other projects need it. @petzlux, can I merge camptocamp/ngeo#283 and this PR? We can address the remaining issues together when this is merged. |
I'll obviously remove the last commit before merging. |
@elemoine Here you can see the behaviour, only if there is a single result does the poi/adress search result get displayed. Hope this helps |
It does help. I think we're hitting twitter/typeahead.js#1319. I'll try to provide a workaround. |
I added a workaround that should fix it. Could you please test again? |
This sets an arbitrary large limit (50) on the "pois" dataset to work around twitter/typeahead.js#1319.
92a03e9
to
d2e8fc2
Compare
Have you been able to verify that 7ca21c0 fixes the problem? May I merge this. |
Cool. I am going to merge camptocamp/ngeo#283, and rebase this PR and merge it. Thanks again for testing. |
d2e8fc2
to
7ca21c0
Compare
We're updating ngeo with version 0.11.1 of typeahead.js. This PR accommodates this update.
Please review and test.
When reviewed and tested I'll merge camptocamp/ngeo#283 and this PR.