Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typeahead.js 0.11.1 #817

Merged
merged 2 commits into from
Aug 19, 2015
Merged

Use typeahead.js 0.11.1 #817

merged 2 commits into from
Aug 19, 2015

Conversation

elemoine
Copy link
Contributor

We're updating ngeo with version 0.11.1 of typeahead.js. This PR accommodates this update.

Please review and test.

When reviewed and tested I'll merge camptocamp/ngeo#283 and this PR.

@elemoine elemoine force-pushed the elemoine_typeahead branch from 5abb82b to a92712a Compare August 11, 2015 13:41
@elemoine
Copy link
Contributor Author

@petzlux, could you please test this?

@petzlux
Copy link
Contributor

petzlux commented Aug 12, 2015

@elemoine sorry but after a make -f wepa.mk clean update-node-modules serve the search does not display results from the fulltextsearch.py service. Results are coming back tough.

No error messages either in debug mode

@elemoine
Copy link
Contributor Author

Strange. What if you do a local search (layers)? Is your instance available on devv3 so I can test it myself? Thanks for testing.

@elemoine
Copy link
Contributor Author

I need to merge camptocamp/ngeo#283 as soon as possible, as other projects need it. @petzlux, can I merge camptocamp/ngeo#283 and this PR? We can address the remaining issues together when this is merged.

@elemoine
Copy link
Contributor Author

I'll obviously remove the last commit before merging.

@petzlux
Copy link
Contributor

petzlux commented Aug 18, 2015

@elemoine
http://devv3.geoportail.lu/renaud/theme/main?version=3&zoom=16&X=693049&Y=6395421&lang=lb&layers&opacities&bgLayer=orthogr_2013_global&debug=true

Here you can see the behaviour, only if there is a single result does the poi/adress search result get displayed.

Hope this helps

@elemoine
Copy link
Contributor Author

It does help.

I think we're hitting twitter/typeahead.js#1319. I'll try to provide a workaround.

@elemoine
Copy link
Contributor Author

I added a workaround that should fix it. Could you please test again?

This sets an arbitrary large limit (50) on the "pois" dataset to work around twitter/typeahead.js#1319.
@elemoine elemoine force-pushed the elemoine_typeahead branch from 92a03e9 to d2e8fc2 Compare August 18, 2015 14:33
@elemoine
Copy link
Contributor Author

Have you been able to verify that 7ca21c0 fixes the problem? May I merge this.

@elemoine
Copy link
Contributor Author

Cool. I am going to merge camptocamp/ngeo#283, and rebase this PR and merge it. Thanks again for testing.

@elemoine elemoine force-pushed the elemoine_typeahead branch from d2e8fc2 to 7ca21c0 Compare August 19, 2015 09:11
elemoine pushed a commit that referenced this pull request Aug 19, 2015
@elemoine elemoine merged commit ee972f7 into master Aug 19, 2015
@elemoine elemoine deleted the elemoine_typeahead branch August 19, 2015 09:40
@petzlux petzlux mentioned this pull request Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants