Search: does not work anymore

[jaykayone]

(Firefox on Mac): You cannot choose a result from the search anymore by hitting enter or clicking the result

Might be a build problem ... we'll see

[jaykayone]

@elemoine might this be a regression coming from ngeo?
As @petzlux has not changed anything this week, I wonder where this regression might come from

[elemoine]

This is probably a regression introduced by #817.

[jaykayone]

I get an Error: Pattern length is too long in debug mode (console).

[elemoine]

I don't know what this means…

[elemoine]

Ok, we're fixing a regression introduced in typeahead 0.11.1. The regression is tracked by twitter/typeahead.js#1313. And there is an (unmerged) PR here: twitter/typeahead.js#1207.

One workaround would involve storing the dataset in the suggestion object, but this would require some work, as we handle different suggestion types.

Another option is to try to revert #817. This may just require adding a custom extern type for TypeaheadDataset. Not so bad I think.

It took me 1h to investigate the issue. I'll take me another hour or so to revert #817 and introduce the extern type override.

[elemoine]

I finally decided to make the revert PR. See #849. And it actually took me less than 1h.