Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to typeahead 0.10.5 #849

Merged
merged 4 commits into from
Sep 3, 2015
Merged

Conversation

elemoine
Copy link
Contributor

@elemoine elemoine commented Sep 2, 2015

This reverts the upgrade to typeahead 0.11.1. See #839 for details on why this revert is necessary.

Fixes #839.

@jaykayone
Copy link
Contributor

can this be merged?

@elemoine
Copy link
Contributor Author

elemoine commented Sep 3, 2015

#842 should be merged first, and all the other PRs need to be rebased.

@jaykayone
Copy link
Contributor

OK, let's do this ASAP as the beta site is concerned and I will be really out-of-office starting today

@elemoine
Copy link
Contributor Author

elemoine commented Sep 3, 2015

I have a few (important) PRs waiting for reviews.

@elemoine elemoine force-pushed the elemoine_searchregression branch from eb88b55 to 24cb4ab Compare September 3, 2015 14:18
@pgiraud
Copy link
Contributor

pgiraud commented Sep 3, 2015

I'll have to trust you on this one. Please merge.

@elemoine
Copy link
Contributor Author

elemoine commented Sep 3, 2015

I'll have to trust you on this one. Please merge.

I basically just reverted the commits that updated the project to typeahead 0.11.1.

elemoine pushed a commit that referenced this pull request Sep 3, 2015
…ression

Switch back to typeahead 0.10.5
@elemoine elemoine merged commit b980b46 into master Sep 3, 2015
@elemoine elemoine deleted the elemoine_searchregression branch September 3, 2015 14:29
@elemoine
Copy link
Contributor Author

elemoine commented Sep 3, 2015

OK, let's do this ASAP as the beta site is concerned and I will be really out-of-office starting today

I hope the beta site will be in a better shape now! Sorry for regressions we introduced.

@elemoine
Copy link
Contributor Author

elemoine commented Sep 3, 2015

"I indroduced" I should say :)

@jaykayone
Copy link
Contributor

thanks @elemoine, beta still does not work as expeced, I think @petzlux has to revert something too ... so we wil see on monday. If it is OK, please redeploy on beta.geoportail.lu .... I'll be out of reach

@elemoine
Copy link
Contributor Author

elemoine commented Sep 4, 2015

thanks @elemoine, beta still does not work as expeced, I think @petzlux has to revert something too ... so we wil see on monday. If it is OK, please redeploy on beta.geoportail.lu .... I'll be out of reach

What does not work exactly?

@jaykayone
Copy link
Contributor

search on beta ...

On 4 sept. 2015, at 17:11, Éric Lemoine notifications@github.com wrote:

thanks @elemoine, beta still does not work as expeced, I think @petzlux has to revert something too ... so we wil see on monday. If it is OK, please redeploy on beta.geoportail.lu .... I'll be out of reach

What does not work exactly?


Reply to this email directly or view it on GitHub.

@elemoine
Copy link
Contributor Author

elemoine commented Sep 4, 2015

search on beta ...

Oh you mean feature search… (layer search works as far as I can tell)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants