Update typeahead to v0.11.1 #283
Conversation
| * @return {!angular.JQLite} | ||
| * @param {TypeaheadOptions|string} options | ||
| * @param {...TypeaheadDataset|string} var_dataset | ||
| * @return {!jQuery} |
There was a problem hiding this comment.
Are you sure about this change (from angular.JQLite to jQuery)? Note that there is jQuery.prototype.typeahead when jQuery is used.
There was a problem hiding this comment.
you're right, it's an error
fredj
force-pushed
the
typeahead
branch
3 times, most recently
from
1c2bb04 to
4c79ee9
Compare
|
This change is not backward compatible because the css class names have changed |
fredj
force-pushed
the
typeahead
branch
2 times, most recently
from
e16c0a3 to
93272f4
Compare
|
(It's the default new css classname because typeahead offer to you to rename them. But in every case, events names have changed, so that' not backward compatible) |
|
Geoportail-Luxembourg will be affected but it's not a huge change: search.less needs to be updated |
|
Can we postpone the merging of this PR? I'd like to be able to update the Luxembourg project when this is merged. |
|
@elemoine please merge this PR when you are ready |
| span.twitter-typeahead .tt-suggestion.tt-cursor { | ||
| color: #ffffff; | ||
| background-color: #428bca; | ||
| } |
There was a problem hiding this comment.
Why is this removed completely?
There was a problem hiding this comment.
It's a mistake, I'll fix it
|
Thanks @fredj. I'll soon merge this. |
|
For posterity: when updating the Luxembourg project to use typeahead.js 0.11.1 I hit this bug in typeahead.js: twitter/typeahead.js#1319. I hope this will be fixed in typeahead.js 0.11.2. See Geoportail-Luxembourg/geoportailv3@7ca21c0 for the workaround used in Luxembourg project. |
This reverts commit 4bd17c2.
This change is not backward compatible
Fixes #282.