Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Styles for Angular Material v15 #54

Closed
GeorgDangl opened this issue Dec 21, 2022 · 2 comments · Fixed by #55
Closed

Fix Styles for Angular Material v15 #54

GeorgDangl opened this issue Dec 21, 2022 · 2 comments · Fixed by #55

Comments

@GeorgDangl
Copy link
Owner

I've just recently updated the dependencies to Angular v15. Material has lots of changes, so we need to remove the legacy elements and use the regular ones.

So we need to check that the components all still look good, and everything is working.

I've found one problem, with the cyan 600 theme used, the text color of buttons is black (but it should be white). It looks like there's a bug in Angular Material:
angular/components#26056 (comment)

I think this might be an idea to fix it:
angular/components#6244 (comment)

@GeorgDangl
Copy link
Owner Author

Now I did npm ci and it looked better😀

But I still seem to have an issue, I've got two buttons here (just added them):
image

Both have color="primary" set, but it only works on the top level one in the header, not on the one I've put in the app.components.html file in the demo project.

@GeorgDangl
Copy link
Owner Author

image

Here's an example of how the legacy button is used

@GeorgDangl GeorgDangl linked a pull request Dec 22, 2022 that will close this issue
GeorgDangl added a commit that referenced this issue Dec 23, 2022
…Angular-Material-v15

Fix/fe #54 fix styles for angular material v15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant