Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors not applied in VS 2017 15.7 preview 3 and 4 #16

Closed
mangeg opened this issue Apr 18, 2018 · 14 comments
Closed

Colors not applied in VS 2017 15.7 preview 3 and 4 #16

mangeg opened this issue Apr 18, 2018 · 14 comments
Assignees
Labels
bug solved A issue was solved

Comments

@mangeg
Copy link

mangeg commented Apr 18, 2018

Starting with preview 3 of the 15.7 version of VS 2017 the colorization is no longer working.
It worked as expected in preview 2, but then in preview 3 not longer working. Preview 4 was just released and it has the same problem.

For testing I installed a few other similar extensions and they too seemed to have the same issue.

@mangeg mangeg changed the title Colors not applied in VS 2017 15.7 preview 3+ Colors not applied in VS 2017 15.7 preview 3 and 4 Apr 18, 2018
@GeorgeAlexandria
Copy link
Owner

@mangeg, the preview version of VS often has a few breaking changes for editors formats, You just tried a few other similar extension and found that they too broke.

If I found a some issue on the vscommunity or solution of it, I will get you know (and, of course, try to fix it), but I think that vs team will fix it faster to the stable realesed version 15.7

P.S. I will be grateful if You can provide a more details:
Does activity log have a some error for extension during startup the vs?
Do editor items show in the fonts and colors option?

@mangeg
Copy link
Author

mangeg commented Apr 18, 2018

Yeah, just wanted to make an issue as a heads up in case they are introducing any breaking changes that will persist to the release version. Don't want to be without colors when it is released 😄

The link to the VSCommunity page does not link to an issue. Tried to search for any but couldn't find it.

The editor items do show in the fonts and colors options.
Regarding activity log it seems to load without problems

<entry>
    <record>1197</record>
    <time>2018/04/18 21:47:10.332</time>
    <type>Information</type>
    <source>Extension Manager</source>
    <description>Found &apos;C:\USERS\MAGNU\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\15.0_17CDB4DF\EXTENSIONS\qnnwjv4t.nfi\extension.vsixmanifest&apos;</description>
  </entry>
  <entry>
    <record>1198</record>
    <time>2018/04/18 21:47:10.332</time>
    <type>Information</type>
    <source>Extension Manager</source>
    <description>Successfully loaded extension...</description>
    <path>C:\USERS\MAGNU\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\15.0_17CDB4DF\EXTENSIONS\QNNWJV4T.NFI\</path>
  </entry>
<entry>
    <record>1209</record>
    <time>2018/04/18 21:47:10.337</time>
    <type>Information</type>
    <source>Extension Manager</source>
    <description>Extension is enabled...</description>
    <path>C:\USERS\MAGNU\APPDATA\LOCAL\MICROSOFT\VISUALSTUDIO\15.0_17CDB4DF\EXTENSIONS\QNNWJV4T.NFI\</path>
  </entry>

I checked and in the qnnwjv4t.nfi folder the CoCo files are located. Nothing further logged that I could find.

@GeorgeAlexandria GeorgeAlexandria self-assigned this Apr 19, 2018
@arfmach
Copy link

arfmach commented May 7, 2018

My VSC2017 just updated to 15.7.0 (official release) and the same happened: custom colors aren't applied anymore.

@iMobCoding
Copy link

I can confirm too - VS v15.7.0 breaks custom colors

@GeorgeAlexandria GeorgeAlexandria added bug investigation A issue must be investigated to find it cause and solution labels May 7, 2018
@GeorgeAlexandria
Copy link
Owner

@arfmach, @crmagicxxx, thanks for your attention. I will investigate this issue as soon as possible.

Any info about issue would be helpful.

@arfmach
Copy link

arfmach commented May 7, 2018

@GeorgeAlexandria, my VS doesn't have any Activity Log. Just to let you know that there's no error message.

@GeorgeAlexandria GeorgeAlexandria removed the investigation A issue must be investigated to find it cause and solution label May 7, 2018
@GeorgeAlexandria
Copy link
Owner

GeorgeAlexandria commented May 7, 2018

@mangeg, @crmagicxxx, @arfmach,
Good news: seems that the problem was found and fixed.
Not good news_1: I need more time to test all of cases with a new patch, so you need to wait a several days of patch or you can help to test it taking the pre-release build (or build version by yourself from new sources :) )
Not good news_2: Patch breaks the all saved colors, they will be reset to default values. So resetting wouldn't be fixed, because finish the #3 will be more useful than fixing the resetting.

@iMobCoding
Copy link

Hey @GeorgeAlexandria
I am interested in trying/testing pre-release build. Can you please give me some download link, because I don't know how to build from the source? I want to test how it goes with v15.7

GeorgeAlexandria added a commit that referenced this issue May 9, 2018
* Supported new classification types
* Changed the custom classification types name for a existing classification types.
@GeorgeAlexandria
Copy link
Owner

GeorgeAlexandria commented May 9, 2018

@crmagicxxx,
If you want try to test pre-release you Must save your VS settings or create a backup instance of VS, because I have a few troubles when try to apply some changes to extensions that were installed on my VS and these changes often break my VS that I need to repair it (I don't know what else the VS team broke changed), so I can't yet test installation, updation and deletion CoCo with the patch. But I tested all tests of colorizing that I wanted and it works very well in VS 15.7.

If you still want to test when you know about a possible troubles but don't know how to create backup of settings or don't know how to install, update vsix from command line let me know about it.

You can find pre-release version of .vsix in the here

@iMobCoding
Copy link

@GeorgeAlexandria
Thanks for the update. Unfortunately, I can't afford myself such scenario, I am in the middle of a very important project. Can't risk losing time on repairing VS :( As soon as I finish this, I'll get back and install pre-release...

@mangeg
Copy link
Author

mangeg commented May 10, 2018

I am running the pre-release version, and it works without problem so far in 15.7.1.

@GeorgeAlexandria
Copy link
Owner

GeorgeAlexandria commented May 10, 2018

@mangeg, it's great. By the way, were your previous colors reseted or not?
(Seems that troubles of vs extensions are only to my local environment)

@mangeg
Copy link
Author

mangeg commented May 10, 2018

The colors were reset back to default.

@GeorgeAlexandria
Copy link
Owner

GeorgeAlexandria commented May 13, 2018

Check the latest version of CoCo for vs15 that should fix this issue. Remember that the colors will be reset back to default values in the last version.

If you have a some issues to install, update or delete extensions (not just CoCo) in the VS, I recommend you to follow this issue and describe the issue in your case.

@GeorgeAlexandria GeorgeAlexandria added the solved A issue was solved label May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug solved A issue was solved
Projects
None yet
Development

No branches or pull requests

4 participants