-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.4.2 #274
Release 0.4.2 #274
Conversation
TODO: readonly test
# Conflicts: # .travis.yml
Sb/ro prepifg
… algorithm and ii) loop function for processing full ifg array
…ated by default Co-authored-by: Sudipta Basak <basaks@gmail.com>
Sb/refpixel lat lon
…on-the-fly in merge.py
calculation of colourmaps for stack_rate and stack_error on-the-fly
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
=========================================
Coverage ? 93.17%
=========================================
Files ? 26
Lines ? 3207
Branches ? 495
=========================================
Hits ? 2988
Misses ? 137
Partials ? 82
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I confirm that the changes applied to the code working as expected. In my processing I used directly GAMMA generated *tif coherence and interferogram files. So I started from prepfig step.
Following are my observations while processing:
- Multi-looked coherence files generate and saved to the out/ directory using cohmask = ON
- I noticed filenames without _ifg.tif and _coh.tif are also working alright in prepifg step but in case files have two dots (e.g., *.ifg.tif) will show error. For dem file name must ended with _dem.tif in out/ otherwise showing error.
- PNG and KML files generated for stack_error as a default.
- lat/lon of reference pixel is working fine applying manually and automatic in the processing
- reference phase removal printing for each interferograms (this shouldn't display on the screen for each interferogram instead should work on the background and show only "reference phase removal calculation" as orbital step on the processing screen)
- APS correction steps are not displaying on the processing screen.
- colormap.txt files generated for both stack_rate and stack_error files using respective min/max values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested these changes using the Mexico data binary files and default .config file with coherence mask and APS turned ON. Everything is working as expected:
- Full-res and multi-looked coherence files are saved to the /out directory.
- The respective DATA_TYPE was in the header file of both coherence file types.
- The filename tags for ifg and coh are there.
- the X/Y and lat/lon pixel values are added to the multilooked ifg header.
- the KML and quick-look PNG files are created for stack_rate and stack_error.
No changes required, but a thought on the quick-look PNG for stack_error:
- For the Mexico data, it was quite hard to see the pixels with higher sigmas because it was light-red on white. We could consider more contrast, but to be discussed.
Added
conv2tif
step ifcohmask = 1
.prepifg
step ifcohmask = 1
.DATA_TYPE
geotiff header metadata for above coherence files.conv2tif
andprepifg
output files have a tag applied to filename dependenton data type, i.e.
_ifg.tif
,_coh.tif
,_dem.tif
.lat/lon and x/y values; mean and standard deviation of reference window samples.
Stack Rate
error map by default.Changed
prepifg
treats input data files asread only
.during
process
step.refx/y
converted to typeint
.the config file. Pixel x/y values are calculated and used internally.
Stack Rate
masking to a standalone functionpyrate.core.stack.mask_rate
,applied during the
merge
step and add unit tests.Stack Rate
masking if threshold parametermaxsig = 0
.pyrate.core.stack.mask_rate
.pyrate.core.stack
module; expose two functions in documentation:i) single pixel stacking algorithm, and
ii) loop function for processing full ifg array.
pyrate.merge
script; remove duplicated code and create reusablegeneric functions.
the geotiff band.
test
anddev
requirements.Removed
pyrate.core.config
and corresponding tests.utils/colourmap.txt
that was previously used to renderquicklook PNG images is removed.