Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new 'cloud_mask' param to load_ard #1000

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Add new 'cloud_mask' param to load_ard #1000

merged 1 commit into from
Feb 1, 2023

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Feb 1, 2023

Proposed changes

A recent client enquiry revealed a limitation of the current load_ard implementation of multiple cloud masks: at the moment the choice of whether to use Fmask or s2cloudless is tied to the same param (mask_pixel_quality) that decides whether to actually mask out cloudy pixels as NaN​. Users may instead just want to use s2cloudless for filtering to non-cloudy scenes using min_gooddata, without actually applying the mask.

This PR separates the choice of cloud mask from the choice of whether to actually mask out clouds as NaN​ pixels by removing the choice of cloud mask from the mask_pixel_quality param, and introducing a new cloud_mask param that controls the choice of cloud mask. This allows users to e.g. filter to non-cloudy cloudy scenes using min_gooddata + s2cloudless, but not actually have to apply the cloud mask to their data.

Have updated the Using_load_ard.ipynb and DEA_Sentinel2_Surface_Reflectance.ipynb notebooks to update them for this change.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@robbibt robbibt changed the title Add new 'cloud_mask' param Add new 'cloud_mask' param to load_ard Feb 1, 2023
@robbibt robbibt marked this pull request as ready for review February 1, 2023 01:41
@robbibt robbibt merged commit cc4d103 into develop Feb 1, 2023
@robbibt robbibt deleted the load_ard_update branch February 1, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants