Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated many links to ensure the links work on the new DEA Knowledge Hub site #1156

Closed
wants to merge 11 commits into from

Conversation

benji-glitsos-ga
Copy link
Collaborator

Proposed changes

Updated many links to ensure the links work on the new DEA Knowledge Hub site

Closes issues (optional)

None

Checklist (replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@benji-glitsos-ga benji-glitsos-ga changed the base branch from develop to stable December 12, 2023 01:12
@treefern
Copy link
Collaborator

treefern commented Dec 12, 2023

Looks like this didn't work as expected 😅 (I'm still a reviewer somehow...)
#1150

@robbibt
Copy link
Member

robbibt commented Dec 12, 2023

@treefern That's just because the change in that PR hasn't been merged across to stable yet (and this PR was made directly to stable) - it will clear up once we do that!

@treefern
Copy link
Collaborator

Oops, I neglected that they weren't both targeting a dev branch. Thanks Robbi :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants