Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates for NCI environment compatibility #1256

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Minor updates for NCI environment compatibility #1256

merged 7 commits into from
Aug 5, 2024

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Aug 5, 2024 •
edited
Loading

Proposed changes

This PR makes two minor changes to hopefully allow tests to run sucessfully on the NCI:

  • Explicitly declare "output_crs" in temporal tests, as load hints don't appear to be set up correctly on NCI
  • Add "skip_broken_datasets" to work around missing datasets/indexing issues

@robbibt robbibt changed the title Update test_temporal.py Minor updates for NCI environment compatibility Aug 5, 2024
@robbibt robbibt marked this pull request as ready for review August 5, 2024 06:11
Ariana-B
Ariana-B approved these changes Aug 5, 2024
View reviewed changes
Tests/dea_tools/test_temporal.py Outdated Show resolved Hide resolved
@robbibt robbibt merged commit b72ae2b into develop Aug 5, 2024
1 check passed
@robbibt robbibt deleted the nci_compat branch August 5, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ariana-B Ariana-B Ariana-B approved these changes

@BexDunn BexDunn Awaiting requested review from BexDunn BexDunn is a code owner

@erialC-P erialC-P Awaiting requested review from erialC-P erialC-P is a code owner

@uchchwhash uchchwhash Awaiting requested review from uchchwhash uchchwhash is a code owner

@Kooie-cate Kooie-cate Awaiting requested review from Kooie-cate Kooie-cate is a code owner

@geoscience-aman geoscience-aman Awaiting requested review from geoscience-aman geoscience-aman is a code owner

@JM-GA JM-GA Awaiting requested review from JM-GA JM-GA is a code owner

@margaretharrison margaretharrison Awaiting requested review from margaretharrison margaretharrison is a code owner

@vnewey vnewey Awaiting requested review from vnewey vnewey is a code owner

@amanda2099 amanda2099 Awaiting requested review from amanda2099 amanda2099 is a code owner

@supermarkion supermarkion Awaiting requested review from supermarkion supermarkion is a code owner

@erin-telfer erin-telfer Awaiting requested review from erin-telfer erin-telfer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbibt @Ariana-B