Convert datetimes explicitly to int64 not int #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On at least one platform (Windows I think) I've seen while working with someone else
int
can be a 32-bit integer and the conversion from numpy datetime64/timedelta64 objects fail to convert to 32-bit integers (fair enough due to overflow possibilities). But we don't care about the size of the integer, we just want the conversion to work, and so I've changed to explicitly converting to 64-bit integers.There's generally also some suspicious stuff going on in gn_datetime but I didn't bother looking at it at this stage, just making the minimal changes needed at this stage.