Npi 3290 clearer error on empty sinex header extras #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronaldmaj
approved these changes
Jun 6, 2024
| # read line that starts with %=SNX and parse it into dict | ||
| snx_bytes = _gn_io.common.path2bytes(path_or_bytes) | ||
| header_begin = snx_bytes.find(b"%=SNX") | ||
| if (header_begin == -1): | ||
| raise ValueError("Sinex header missing!", file_desc(path_or_bytes)) |
There was a problem hiding this comment.
I was able to test this and works well
| header_end = snx_bytes.find(b"\n", header_begin) | ||
| if header_end == -1: | ||
| raise ValueError("Sinex header found but wasn't newline terminated (end unclear)", file_desc(path_or_bytes)) |
There was a problem hiding this comment.
I've tried to end up here but wasn't successful in editing an SNX to do so - do you have an example file where you were able to?
| raise ValueError(f"Sinex header is empty for UNKNOWN file (passed in as bytes object not path)") | ||
| else: | ||
| raise ValueError(f"Sinex header is empty for file: '{str(path_or_bytes)}'") | ||
| raise ValueError(f"Sinex header found, but empty!", file_desc(path_or_bytes)) |
There was a problem hiding this comment.
Again, wasn't able to get here.
I've tried just having the %=SNX with nothing afterwards, but the error is around pandas not finding columns I believe:
EmptyDataError: No columns to parse from file
Anyway, none of this is a show stopper so I think it can go in
treefern
deleted the
NPI-3290-clearer-error-on-empty-sinex-header-extras
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.